Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace crossbeam::scope reference with thread::scope in docs #11832

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Replace crossbeam::scope reference with thread::scope in docs #11832

merged 1 commit into from
Feb 12, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Feb 12, 2024

Objective

  • crossbeam::scope is soft-deprecated in favor of the standard library's implementation.

Solution

  • Replace reference in TaskPool's docs to mention std::thread::scope instead.

@BD103
chore(tasks): replace crossbeam::scope with thread::scope
0511114 
`crossbeam::scope` is soft-deprecated in favor of the standard library's implementation. `rayon::scope` is kept because it does something slightly different.
@james7132 james7132 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into bevyengine:main with commit b721aaa Feb 12, 2024
24 checks passed
@BD103 BD103 deleted the thread-scope branch February 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-lua pablo-lua pablo-lua approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BD103 @james7132 @pablo-lua