Have WindowPosition::Centered take scale_factor_override into account #13949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jun 20, 2024
kristoff3r
approved these changes
Jun 20, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
Jun 24, 2024
mockersf
pushed a commit
that referenced
this pull request
Jun 26, 2024
…#13949) # Objective Fixes #8916 My game has a low resolution pixel art style, and I use `.with_scale_factor_override()` to make the window larger. `WindowPosition::Centered` doesn't work for me. ## Solution If `scale_factor_override` is set, use that over `monitor.scale_factor` ## Testing Tested on Windows 11 with an Nvidia GPU: ### Main  ### This PR 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #8916
My game has a low resolution pixel art style, and I use
.with_scale_factor_override()to make the window larger.WindowPosition::Centereddoesn't work for me.Solution
If
scale_factor_overrideis set, use that overmonitor.scale_factorTesting
Tested on Windows 11 with an Nvidia GPU:
Main
This PR