Split zoom/orbit into separate examples #15135
Conversation
|
@janhohenheim as promised! |
NthTensor
added
A-Rendering
There was a problem hiding this comment.
Looks great :D Left some minor improvements.
I also want to note that orbit cameras are traditionally controlled by the mouse, so that may be what the user expects to find here. I'll leave the choice if you want to switch to mouse up to you. If you do so, see the comments in #15109 for how to correctly read and multiply by the motion delta.
You could still use Q and E or some other key for roll, but imo it's fine to also just leave it out. It's very rare that someone needs to adjust the roll of a camera if they're not doing some spaceship simulator or super mario galaxy stuff, and if they need to, they already know how to do it based on this code.
Again, feel free to leave it at keyboard inputs if you believe that choice to be better in this case :)
| delta_pitch *= time.delta_seconds(); | ||
| delta_roll *= time.delta_seconds(); | ||
| delta_yaw *= time.delta_seconds(); |
There was a problem hiding this comment.
| delta_pitch *= time.delta_seconds(); | |
| delta_roll *= time.delta_seconds(); | |
| delta_yaw *= time.delta_seconds(); | |
| let speed = camera_settings.orbit_speed * time.delta_seconds(); | |
| delta_pitch *= speed; | |
| delta_roll *= speed; | |
| delta_yaw *= speed; |
Bit easier to understand where the numbers come from this way :)
| if keyboard_input.pressed(KeyCode::KeyW) { | ||
| delta_pitch += camera_settings.orbit_speed; | ||
| } | ||
| if keyboard_input.pressed(KeyCode::KeyS) { | ||
| delta_pitch -= camera_settings.orbit_speed; | ||
| } | ||
|
|
||
| if keyboard_input.pressed(KeyCode::KeyQ) { | ||
| delta_roll -= camera_settings.orbit_speed; | ||
| } | ||
| if keyboard_input.pressed(KeyCode::KeyE) { | ||
| delta_roll += camera_settings.orbit_speed; | ||
| } | ||
|
|
||
| if keyboard_input.pressed(KeyCode::KeyA) { | ||
| delta_yaw -= camera_settings.orbit_speed; | ||
| } | ||
| if keyboard_input.pressed(KeyCode::KeyD) { | ||
| delta_yaw += camera_settings.orbit_speed; | ||
| } |
There was a problem hiding this comment.
| if keyboard_input.pressed(KeyCode::KeyW) { | |
| delta_pitch += camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyS) { | |
| delta_pitch -= camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyQ) { | |
| delta_roll -= camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyE) { | |
| delta_roll += camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyA) { | |
| delta_yaw -= camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyD) { | |
| delta_yaw += camera_settings.orbit_speed; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyW) { | |
| delta_pitch += 1.0; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyS) { | |
| delta_pitch -= 1.0; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyQ) { | |
| delta_roll -= 1.0; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyE) { | |
| delta_roll += 1.0; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyA) { | |
| delta_yaw -= 1.0; | |
| } | |
| if keyboard_input.pressed(KeyCode::KeyD) { | |
| delta_yaw += 1.0; | |
| } |
See comment below in the code or above (for some reason) when looking at the GitHub discussion
| Name::new("Fox"), | ||
| SceneBundle { | ||
| scene: asset_server | ||
| .load(GltfAssetLabel::Scene(0).from_asset("models/animated/Fox.glb")), |
There was a problem hiding this comment.
TIL of this syntax 👀 Is this better than assert_server.load("models/animated/Fox.glb#Scene0")?
There was a problem hiding this comment.
Not necessarily! Yanked straight from one of our other examples. Not sure if "better", possibly exposes to editor/LSP help? Since it's not just a string...
There was a problem hiding this comment.
I like it better because it's harder to typo.
| // Adjust the translation to maintain the correct orientation toward the orbit target. | ||
| transform.translation = Vec3::ZERO - transform.forward() * camera_settings.orbit_distance; |
There was a problem hiding this comment.
| // Adjust the translation to maintain the correct orientation toward the orbit target. | |
| transform.translation = Vec3::ZERO - transform.forward() * camera_settings.orbit_distance; | |
| // Adjust the translation to maintain the correct orientation toward the orbit target. | |
| let target = Vec3::ZERO; | |
| transform.translation = target - transform.forward() * camera_settings.orbit_distance; |
That should make it a bit more obvious how to customize this code
janhohenheim
added
S-Ready-For-Final-Review
But... surely they're making an Elite clone! 😆 |
|
@NthTensor regarding the fox, the scaling is not the only thing that's suboptimal unfortunately: #8099 |
I mean, it's labelled Trivial so if I continue my backwards quest through the oldest trivial tickets in the backlog I'll eventually get to it 😉 |
|
@janhohenheim next looks? I couldn't resist keeping roll in, because I played too much Elite as a youth. It's possibly a tiny bit difficult to control, but seems to work OK. |
|
Oops! Let's make that a separate PR 😆 |
# Objective Applies feedback from previous PR #15135 'cause it got caught up in the merge train 🚂 I couldn't resist including roll, both for completeness and due to playing too many games that implemented it as a child. cc: @janhohenheim
Objective
As previously discussed, split camera zoom and orbiting examples to keep things less cluttered. See discussion on #15092 for context.