Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the UI texture slice pipeline to work with the retained render world changes #15578

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Update the UI texture slice pipeline to work with the retained render world changes #15578

merged 1 commit into from
Oct 1, 2024

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Oct 1, 2024 •
edited
Loading

Objective

Update the UI's texture slice extraction to work with the changes from the retained render world PR (#15320).

@ickshonpe ickshonpe changed the title Update UI rendering to work with the retained render world changes Update the UI texture slice pipeline to work with the retained render world changes Oct 1, 2024
@alice-i-cecile alice-i-cecile self-requested a review October 1, 2024 20:59
alice-i-cecile
alice-i-cecile approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me. Thanks for fixing this up.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Oct 1, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 1, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 1, 2024
Trashtalk217
Trashtalk217 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Trashtalk217 Trashtalk217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick PR!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 1, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 1, 2024
Merged via the queue into bevyengine:main with commit f53af28 Oct 1, 2024
32 checks passed
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 4, 2024
@ickshonpe @robtfm
Update the UI texture slice pipeline to work with the retained render…
83c137d 
… world changes (bevyengine#15578)

# Objective

Update the UI's texture slice extraction to work with the changes from
the retained render world PR (bevyengine#15320).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@Trashtalk217 Trashtalk217 Trashtalk217 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@ickshonpe @alice-i-cecile @Trashtalk217 @BenjaminBrienen