Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global clear color for camera driver node. #15688

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Use global clear color for camera driver node. #15688

merged 3 commits into from
Oct 7, 2024

Conversation

tychedelia
Copy link
Contributor

When no cameras are configured, the ClearColor resource has no effect on the default window.

Fixes https://discord.com/channels/691052431525675048/866787577687310356/1292601838075379796

image
image

@tychedelia tychedelia added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible labels Oct 7, 2024
@tychedelia tychedelia requested a review from IceSentry October 7, 2024 01:41
@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 7, 2024
Merged via the queue into bevyengine:main with commit 0374648 Oct 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tychedelia @bushrat011899 @alice-i-cecile @IceSentry