Fix alien_cake_addict example
#16281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBrienen
added
A-ECS
alice-i-cecile
approved these changes
Nov 7, 2024
LiamGallagher737
approved these changes
Nov 7, 2024
|
I am missing something. Could you help me understand the underlying bug and why these changes fix it? |
The lighting bugs out due to too many entities being despawned. See the video in the issue. |
|
I understood what the bug is, but not why this is fixing it. I was able to dig up the related conversation in discord though. It seems that the previous method of tearing down the scene was likely despawning an important |
rparrett
approved these changes
Nov 7, 2024
BenjaminBrienen
removed
the
S-Needs-Review
mockersf
pushed a commit
that referenced
this pull request
Nov 11, 2024
# Objective Fixes #15729 ## Solution Use the state-scoped pattern. ## Testing Tested manually. See the showcase. --- ## Showcase https://github.com/user-attachments/assets/14ffefca-40c6-4c7e-b15b-f92466a2b0a5
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective Fixes bevyengine#15729 ## Solution Use the state-scoped pattern. ## Testing Tested manually. See the showcase. --- ## Showcase https://github.com/user-attachments/assets/14ffefca-40c6-4c7e-b15b-f92466a2b0a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #15729
Solution
Use the state-scoped pattern.
Testing
Tested manually. See the showcase.
Showcase
Screen.Recording.2024-11-07.201740.mp4