Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - enable change detection for hierarchy maintenance #2411

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - enable change detection for hierarchy maintenance #2411

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Noticed a comment saying changed detection should be enabled for hierarchy maintenance once stable

Fixes #891

Solution

Added Changed<Parent> filter on the query

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jun 28, 2021
@NathanSWard NathanSWard added C-Code-Quality A section of code that is hard to understand or change A-Core Common functionality for all bevy apps and removed S-Needs-Triage This issue needs to be labelled labels Jun 29, 2021
@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@alice-i-cecile alice-i-cecile added A-Transform Translations, rotations and scales C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review labels Sep 22, 2021
@bjorn3 bjorn3 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Sep 23, 2021
@cart
Copy link
Member

cart commented Sep 27, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 27, 2021
@mockersf
enable change detection for hierarchy maintenance (#2411)
fb0aa8d 
# Objective

Noticed a comment saying changed detection should be enabled for hierarchy maintenance once stable

Fixes #891


## Solution

Added `Changed<Parent>` filter on the query
@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title enable change detection for hierarchy maintenance [Merged by Bors] - enable change detection for hierarchy maintenance Sep 27, 2021
@bors bors bot closed this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inodentry inodentry inodentry approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@payload payload payload approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps A-Transform Translations, rotations and scales C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spawning a child entity in or after POST_UPDATE won't be properly registred as child of the parent
7 participants
@mockersf @cart @payload @alice-i-cecile @bjorn3 @inodentry @NathanSWard