[Merged by Bors] - Add Gamepads resource #3257
Conversation
alice-i-cecile
added
A-Input
|
Looks great! Thanks for tackling this :) I would like to see some basic docs, since this is part of the public API now, but otherwise this LGTM. |
|
I've added the |
|
Thinking about this a bit further, I think that |
|
Great! You have my approval :) @CrazyRoka, you should click "Resolve Comment" on the comments that I've left so this PR's state is easier to follow for future reviewers. |
alice-i-cecile
added
S-Ready-For-Final-Review
|
@alice-i-cecile @MinerSebas Can you review my updates? |
crates/bevy_input/src/gamepad.rs
Outdated
| /// | ||
| /// [Gamepad]s are registered and deregistered in [gamepad_connection_system] | ||
| pub struct GamepadLobby { | ||
| pub gamepads: HashSet<Gamepad>, |
There was a problem hiding this comment.
This is an implementation detail that we shouldn't expose directly to users (who could accidentally remove "active" gamepad and break guarantees that this list contains "active" gamepads). Instead, lets make this private and implement a method like GamepadLobby::contains(index: usize)
There was a problem hiding this comment.
Eh actually we should probably accept the Gamepad type for consistency with other apis, but I think we should consider making the index private to encourage people to treat Gamepad as an opaque type that must be queried for. And if we don't want that behavior (and want user-specified ids to be a part of our api), then we should consider removing the Gamepad wrapper type.
Also, lets add GamepadLobby::iter() so users can iterate active gamepads.
There was a problem hiding this comment.
- Made this field private
- Added
contains(gamepad: Gamepad)method - Added
iter()method - Replaced usages with these methods
- Added
registerandderegisterprivate methods
crates/bevy_input/src/gamepad.rs
Outdated
| /// Container of unique connected [Gamepad]s | ||
| /// | ||
| /// [Gamepad]s are registered and deregistered in [gamepad_connection_system] | ||
| pub struct GamepadLobby { |
There was a problem hiding this comment.
I agree that GamepadLobby isn't the best name for this. Lets use the more descriptive ActiveGamepads unless someone can think of something better.
There was a problem hiding this comment.
Yeah I like Gamepads more because it is terser
There was a problem hiding this comment.
Renamed it to Gamepads
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
|
bors r+ |
|
Canceled. |
cart
changed the title
|
bors r+ |
# Objective Fixes #3245 ## Solution - Move GamepadLobby to lib - Add connection_system to InputPlugin - Updated gamepad_input example Co-authored-by: CrazyRoka <rokarostuk@gmail.com> Co-authored-by: Carter Anderson <mcanders1@gmail.com>
|
Build failed: |
|
bors r+ |
# Objective Fixes #3245 ## Solution - Move GamepadLobby to lib - Add connection_system to InputPlugin - Updated gamepad_input example Co-authored-by: CrazyRoka <rokarostuk@gmail.com> Co-authored-by: Carter Anderson <mcanders1@gmail.com>
bors
bot
changed the title
Objective
Fixes #3245
Solution