Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make the fields of the Material2dKey public #5212

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make the fields of the Material2dKey public #5212

wants to merge 1 commit into from

Conversation

TethysSvensson
Copy link
Contributor

Objective

Make it easier to create pipelines derived from the Material2dPipeline. Currently this is made difficult because the fields of Material2dKey are private.

Solution

Make the fields public.

@mockersf
Copy link
Member

mockersf commented Jul 5, 2022

same as #4508

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 5, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 5, 2022
@TethysSvensson
Make the fields of the Material2dKey public (#5212)
aa0cd7c 
# Objective

Make it easier to create pipelines derived from the `Material2dPipeline`. Currently this is made difficult because the fields of `Material2dKey` are private.

## Solution

Make the fields public.
@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make the fields of the Material2dKey public [Merged by Bors] - Make the fields of the Material2dKey public Jul 5, 2022
@bors bors bot closed this Jul 5, 2022
@TethysSvensson TethysSvensson deleted the material-2d-key branch July 5, 2022 14:42
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
@TethysSvensson @inodentry
Make the fields of the Material2dKey public (bevyengine#5212)
04b11e9 
# Objective

Make it easier to create pipelines derived from the `Material2dPipeline`. Currently this is made difficult because the fields of `Material2dKey` are private.

## Solution

Make the fields public.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@TethysSvensson @james7132
Make the fields of the Material2dKey public (bevyengine#5212)
0ac6c6b 
# Objective

Make it easier to create pipelines derived from the `Material2dPipeline`. Currently this is made difficult because the fields of `Material2dKey` are private.

## Solution

Make the fields public.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@TethysSvensson @ItsDoot
Make the fields of the Material2dKey public (bevyengine#5212)
ee7b4bf 
# Objective

Make it easier to create pipelines derived from the `Material2dPipeline`. Currently this is made difficult because the fields of `Material2dKey` are private.

## Solution

Make the fields public.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TethysSvensson @mockersf @alice-i-cecile