[Merged by Bors] - Conversion of ResMut and NonSendMut to Mut
#5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `into_mut()` method allowing to convert a `ResMut` or `NonSendMut` into a simple `Mut`. This enables treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component).
|
I like the idea! IMO this should just be a |
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jul 23, 2022
maniwani
approved these changes
Jul 24, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
# Objective Enable treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component). ## Solution Implement `From<ResMut<T>>` and `From<NonSendMut<T>>` for `Mut`. Since the 3 structs are similar, and only differ by their system param role, the conversion is trivial. --- ## Changelog Added - `From<ResMut>` and `From<NonSendMut>` for `Mut<T>`.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
# Objective Enable treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component). ## Solution Implement `From<ResMut<T>>` and `From<NonSendMut<T>>` for `Mut`. Since the 3 structs are similar, and only differ by their system param role, the conversion is trivial. --- ## Changelog Added - `From<ResMut>` and `From<NonSendMut>` for `Mut<T>`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ResMut and NonSendMut to MutResMut and NonSendMut to Mut
djeedai
commented
Jul 25, 2022
| @@ -206,6 +217,17 @@ change_detection_impl!(NonSendMut<'a, T>, T,); | |||
| impl_into_inner!(NonSendMut<'a, T>, T,); | |||
| impl_debug!(NonSendMut<'a, T>,); | |||
|
|
|||
| impl<'a, T: Resource> From<NonSendMut<'a, T>> for Mut<'a, T> { | |||
There was a problem hiding this comment.
This is wrong, should have been:
Suggested change
| impl<'a, T: Resource> From<NonSendMut<'a, T>> for Mut<'a, T> { | |
| impl<'a, T: 'static> From<NonSendMut<'a, T>> for Mut<'a, T> { |
FYI @alice-i-cecile , @maniwani
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective Enable treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component). ## Solution Implement `From<ResMut<T>>` and `From<NonSendMut<T>>` for `Mut`. Since the 3 structs are similar, and only differ by their system param role, the conversion is trivial. --- ## Changelog Added - `From<ResMut>` and `From<NonSendMut>` for `Mut<T>`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Enable treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component). ## Solution Implement `From<ResMut<T>>` and `From<NonSendMut<T>>` for `Mut`. Since the 3 structs are similar, and only differ by their system param role, the conversion is trivial. --- ## Changelog Added - `From<ResMut>` and `From<NonSendMut>` for `Mut<T>`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Enable treating components and resources equally, which can simplify the implementation of some systems where only the change detection feature is relevant and not the kind of object (resource or component). ## Solution Implement `From<ResMut<T>>` and `From<NonSendMut<T>>` for `Mut`. Since the 3 structs are similar, and only differ by their system param role, the conversion is trivial. --- ## Changelog Added - `From<ResMut>` and `From<NonSendMut>` for `Mut<T>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Enable treating components and resources equally, which can
simplify the implementation of some systems where only the change
detection feature is relevant and not the kind of object (resource or
component).
Solution
Implement
From<ResMut<T>>andFrom<NonSendMut<T>>forMut. Since the 3 structs are similar, and only differ by their systemparam role, the conversion is trivial.
Changelog
Added -
From<ResMut>andFrom<NonSendMut>forMut<T>.