Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Deduplicate ambiguity reporting code #6149

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Deduplicate ambiguity reporting code #6149

wants to merge 1 commit into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Oct 3, 2022

Objective

Now that #6083 has been merged, we can clean up some ugly ambiguity detection code.

Solution

Deduplicate code.

alice-i-cecile
alice-i-cecile approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 You have no idea how badly I wanted to be able to do this.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Oct 3, 2022
@JoJoJet JoJoJet marked this pull request as ready for review October 3, 2022 03:12
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 3, 2022
@mockersf
Copy link
Member

mockersf commented Oct 3, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 3, 2022
@JoJoJet
Deduplicate ambiguity reporting code (#6149)
8a26812 
# Objective

Now that #6083 has been merged, we can clean up some ugly ambiguity detection code.

# Solution

Deduplicate code.
@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Deduplicate ambiguity reporting code [Merged by Bors] - Deduplicate ambiguity reporting code Oct 3, 2022
@bors bors bot closed this Oct 3, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
@JoJoJet @james7132
Deduplicate ambiguity reporting code (bevyengine#6149)
fb20671 
# Objective

Now that bevyengine#6083 has been merged, we can clean up some ugly ambiguity detection code.

# Solution

Deduplicate code.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@JoJoJet @james7132
Deduplicate ambiguity reporting code (bevyengine#6149)
d04175c 
# Objective

Now that bevyengine#6083 has been merged, we can clean up some ugly ambiguity detection code.

# Solution

Deduplicate code.
@JoJoJet JoJoJet deleted the ambiguity-refactor branch December 1, 2022 15:05
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Deduplicate ambiguity reporting code (bevyengine#6149)
7155a51 
# Objective

Now that bevyengine#6083 has been merged, we can clean up some ugly ambiguity detection code.

# Solution

Deduplicate code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoJoJet @mockersf @alice-i-cecile @tim-blackbird