[Merged by Bors] - Fix tests breaking when new WorldQuery impls are added #6317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
added
A-ECS
mockersf
approved these changes
Oct 20, 2022
james7132
approved these changes
Oct 21, 2022
mockersf
added
the
S-Ready-For-Final-Review
tim-blackbird
approved these changes
Oct 21, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
# Objective I recently wanted to look at the possibility of adding `Mutated` and `Unchanged` query filters and was confronted with some seemingly unrelated broken tests. These tests were written in such a way that changing the number of WorldQuery impls in the project would break them. Fortunately, a [very recent release of trybuild](https://github.com/dtolnay/trybuild/releases/tag/1.0.70) has made this unnecessary. ## Solution Replace hardcoded numbers in test output with `$N` placeholders.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# Objective This is a follow-up to #6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# Objective This is a follow-up to #6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective I recently wanted to look at the possibility of adding `Mutated` and `Unchanged` query filters and was confronted with some seemingly unrelated broken tests. These tests were written in such a way that changing the number of WorldQuery impls in the project would break them. Fortunately, a [very recent release of trybuild](https://github.com/dtolnay/trybuild/releases/tag/1.0.70) has made this unnecessary. ## Solution Replace hardcoded numbers in test output with `$N` placeholders.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective This is a follow-up to bevyengine#6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective I recently wanted to look at the possibility of adding `Mutated` and `Unchanged` query filters and was confronted with some seemingly unrelated broken tests. These tests were written in such a way that changing the number of WorldQuery impls in the project would break them. Fortunately, a [very recent release of trybuild](https://github.com/dtolnay/trybuild/releases/tag/1.0.70) has made this unnecessary. ## Solution Replace hardcoded numbers in test output with `$N` placeholders.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective I recently wanted to look at the possibility of adding `Mutated` and `Unchanged` query filters and was confronted with some seemingly unrelated broken tests. These tests were written in such a way that changing the number of WorldQuery impls in the project would break them. Fortunately, a [very recent release of trybuild](https://github.com/dtolnay/trybuild/releases/tag/1.0.70) has made this unnecessary. ## Solution Replace hardcoded numbers in test output with `$N` placeholders.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective This is a follow-up to bevyengine#6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I recently wanted to look at the possibility of adding
MutatedandUnchangedquery filters and was confronted with some seemingly unrelated broken tests.These tests were written in such a way that changing the number of WorldQuery impls in the project would break them.
Fortunately, a very recent release of trybuild has made this unnecessary.
Solution
Replace hardcoded numbers in test output with
$Nplaceholders.