[Merged by Bors] - Use wgsl saturate #6318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl. naga's version allows usage for not only scalars but vectors as well. ## Solution Remove the utils.wgsl saturate function. ## Changelog Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0. Signed-off-by: Torstein Grindvik <torstein.grindvik@nordicsemi.no>
rparrett
approved these changes
Oct 20, 2022
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Oct 20, 2022
|
Doesn't appear to be in the changelog, but I can verify its existence in the code. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Third item in the changelog. I think that CI would have caught that. I did test the lighting example (and on wasm) just for good measure. |
mockersf
approved these changes
Oct 20, 2022
IceSentry
approved these changes
Oct 22, 2022
DGriffin91
approved these changes
Oct 22, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2022
# Objective Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl. naga's version allows usage for not only scalars but vectors as well. ## Solution Remove the utils.wgsl saturate function. ## Changelog Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
|
Pull request successfully merged into main. Build succeeded: |
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl. naga's version allows usage for not only scalars but vectors as well. ## Solution Remove the utils.wgsl saturate function. ## Changelog Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
# Objective Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl. naga's version allows usage for not only scalars but vectors as well. ## Solution Remove the utils.wgsl saturate function. ## Changelog Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl. naga's version allows usage for not only scalars but vectors as well. ## Solution Remove the utils.wgsl saturate function. ## Changelog Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Use saturate wgsl function now implemented in naga (version 0.10.0). There is now no need for one in utils.wgsl.
naga's version allows usage for not only scalars but vectors as well.
Solution
Remove the utils.wgsl saturate function.
Changelog
Remove saturate function from utils.wgsl in favor of saturate in naga v0.10.0.