-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix: specify required trybuild patch version #6333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataphract
added
C-Dependencies
A change to the crates that Bevy depends on
C-Testing
A change that impacts how we test Bevy or how users test their apps
labels
Oct 22, 2022
mockersf
approved these changes
Oct 22, 2022
alice-i-cecile
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Oct 25, 2022
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# Objective This is a follow-up to #6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# Objective This is a follow-up to #6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
bors
bot
changed the title
fix: specify required trybuild patch version
[Merged by Bors] - fix: specify required trybuild patch version
Oct 25, 2022
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective This is a follow-up to bevyengine#6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective This is a follow-up to bevyengine#6317, which makes use of a feature of the newest `trybuild` version, `1.0.71`, but does not specify the new patch version in `bevy_ecs_compile_fail_tests/Cargo.toml`. The PR passed CI because CI downloaded the latest `trybuild` version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a `^1.0` version of `trybuild` cached locally, which causes the new `$N` syntax to fail the tests. ## Solution Updated the `trybuild` requirement to `1.0.71`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Dependencies
A change to the crates that Bevy depends on
C-Testing
A change that impacts how we test Bevy or how users test their apps
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is a follow-up to #6317, which makes use of a feature of the newest
trybuild
version,1.0.71
, but does not specify the new patch version inbevy_ecs_compile_fail_tests/Cargo.toml
.The PR passed CI because CI downloaded the latest
trybuild
version satisfying the dependency specification. However, Cargo will not know an update is required if a user already has a^1.0
version oftrybuild
cached locally, which causes the new$N
syntax to fail the tests.Solution
Updated the
trybuild
requirement to1.0.71
.