Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make Entity::to_bits const #6559

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make Entity::to_bits const #6559

wants to merge 1 commit into from

Conversation

james7132
Copy link
Member

Objective

Fix #6548. Most of these methods were already made const in #5688. Entity::to_bits is the only one that remained.

Solution

Make it const.

@james7132 james7132 added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 12, 2022
alice-i-cecile
alice-i-cecile approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Nov 12, 2022
@james7132
Make Entity::to_bits const (#6559)
2179a3e 
# Objective
Fix #6548. Most of these methods were already made `const` in #5688. `Entity::to_bits` is the only one that remained.

## Solution
Make it const.
@bors
Copy link
Contributor

bors bot commented Nov 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make Entity::to_bits const [Merged by Bors] - Make Entity::to_bits const Nov 12, 2022
@bors bors bot closed this Nov 12, 2022
@james7132 james7132 deleted the entity-const branch November 18, 2022 04:18
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@james7132 @ItsDoot
Make Entity::to_bits const (bevyengine#6559)
8edc264 
# Objective
Fix bevyengine#6548. Most of these methods were already made `const` in bevyengine#5688. `Entity::to_bits` is the only one that remained.

## Solution
Make it const.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Methods on Entity should be const
3 participants
@james7132 @alice-i-cecile @tim-blackbird