Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set cursor hittest during window creation #7966

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Set cursor hittest during window creation #7966

merged 1 commit into from
Mar 9, 2023

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Mar 8, 2023

Objective

  • Set cursor hittest during window creation, not need to set hittest in a system.

alice-i-cecile
alice-i-cecile approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hit test docs are here, for anyone else curious. Piping that through definitely seems correct.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in labels Mar 8, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 8, 2023
@james7132 james7132 added this pull request to the merge queue Mar 9, 2023
Merged via the queue into bevyengine:main with commit 84711e3 Mar 9, 2023
@mockersf mockersf mentioned this pull request Mar 9, 2023
Merged
@mockersf
Copy link
Member

mockersf commented Mar 9, 2023

The hit test docs are here

As mentioned in the docs, this will always fail on some platforms, which means always setting it will log an unfixable warning.

I opened #7996 to fix that.

Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@lewiszlw @Shfty
Set cursor hittest during window creation (bevyengine#7966)
bfe079c
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@lewiszlw @Shfty
Set cursor hittest during window creation (bevyengine#7966)
bd56916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewiszlw @mockersf @james7132 @alice-i-cecile