Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color::Lcha constructors #8041

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Color::Lcha constructors #8041

merged 2 commits into from
Mar 11, 2023

Conversation

payload
Copy link
Contributor

@payload payload commented Mar 11, 2023

Objective

  • With 0.10.0 the Color enum got an additional Lcha variant but misses function constructors for it similar to Color::rgb(r, g, b)

Solution

  • Added Color::lch and Color::lcha functions

⚠️ There is the PR #8040 which needs to be merged first because of this test and a refactoring in it.

Changelog

Added

  • Added Color::lch and Color::lcha functions

@payload payload force-pushed the color-lcha-constructor branch from 4a98f1b to ffa6c5f Compare March 11, 2023 12:48
@payload
Copy link
Contributor Author

payload commented Mar 11, 2023

#8040 is merged now and this is rebased 🌈

@mockersf mockersf added A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 11, 2023
james7132
james7132 reviewed Mar 11, 2023
View reviewed changes
crates/bevy_render/src/color/mod.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/color/mod.rs Outdated Show resolved Hide resolved
@james7132 james7132 enabled auto-merge March 11, 2023 18:36
@james7132 james7132 added this pull request to the merge queue Mar 11, 2023
Merged via the queue into bevyengine:main with commit 7d5f89c Mar 11, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@payload @james7132 @Shfty
Color::Lcha constructors (bevyengine#8041)
b430714 
Co-authored-by: James Liu <contact@jamessliu.com>
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@payload @james7132 @Shfty
Color::Lcha constructors (bevyengine#8041)
57a4d7a 
Co-authored-by: James Liu <contact@jamessliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@payload @james7132 @mockersf