bevy_derive: Fix #[deref] breaking other attributes
#9551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Bug
mockersf
requested changes
Aug 23, 2023
crates/bevy_macros_compile_fail_tests/tests/deref_mut_derive/missing_deref.fail.stderr
Outdated
Show resolved
Hide resolved
crates/bevy_macros_compile_fail_tests/tests/deref_mut_derive/missing_deref.fail.stderr
Outdated
Show resolved
Hide resolved
Co-authored-by: François <mockersf@gmail.com>
mockersf
approved these changes
Aug 23, 2023
hymm
approved these changes
Aug 24, 2023
hymm
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Fixes bevyengine#9550 ## Solution Removes a check that asserts that _all_ attribute metas are path-only, rather than just the `#[deref]` attribute itself. --- ## Changelog - Fixes an issue where deriving `Deref` with `#[deref]` on a field causes other attributes to sometimes result in a compile error --------- Co-authored-by: François <mockersf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #9550
Solution
Removes a check that asserts that all attribute metas are path-only, rather than just the
#[deref]attribute itself.Changelog
Derefwith#[deref]on a field causes other attributes to sometimes result in a compile error