Allow clippy::type_complexity in more places.

[waywardmonkeys]

Objective

• See fewer warnings when running cargo clippy locally.

Solution

• allow clippy::type_complexity in more places, which also signals to users they should do the same.

[IceSentry]

When running clippy in CI we use pre configured lints because we don't want to pollute the repo with a bunch of annotations like that.

Personally, I added this config to my rust analyzer to use the same lints as bevy

   "rust-analyzer.check.command": "clippy",
   "rust-analyzer.check.extraArgs": [
      "--all-features",
      "--",
      "-Aclippy::type_complexity",
      "-Wclippy::doc_markdown",
      "-Wclippy::redundant_else",
      "-Wclippy::match_same_arms",
      "-Wclippy::semicolon_if_nothing_returned",
      "-Wclippy::explicit_iter_loop",
      "-Wclippy::map_flatten",
      "-Dwarnings"
  ],

[waywardmonkeys]

I thought about that, but there were already about 37 of these in the code (every crate basically except the new asset crate).

[JoJoJet]

We should do this -- see #8313 which did this for everything except for our examples. Initially I didn't do this for the examples because it just seemed like a lot, but given that disabling this lint is considered best practice, it's a good idea to teach users via our examples.

We should add a comment to each one, something like

// This lint usually gives bad advice in the context of Bevy -- hiding complex queries behind
// type alias tends to obfuscate code while offering no improvement in code cleanliness.

I'd go a step further and remove the lint suppression from CI, so we have only one source of truth for this lint (which was the opinion cart originally expressed in the aforementioned PR).

[waywardmonkeys]

I'll update this. To avoid a conflict, we'll need #9794 to land before this.

[waywardmonkeys]

I removed -A clippy::type_complexity from CI as discussed above and elsewhere. If examples change in such a way that they start to trigger, then they would need to be updated since this PR doesn't edit every single example, only those that currently trigger the lint.

[alice-i-cecile]

@waywardmonkeys can you fix merge conflicts and then I'll merge?

[waywardmonkeys]

Sure thing. I am almost done with dinner and then will do it

[waywardmonkeys]

@alice-i-cecile Done! Hopefully everything is correct with the latest push.