{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":830182988,"defaultBranch":"master","name":"cookie","ownerLogin":"bewinsnw","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-07-17T19:02:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/119598239?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1721243797.0","currentOid":""},"activityList":{"items":[{"before":"32046d43e378b4403e163b9cfc230aa91c343436","after":"22e5f22bf89ecfed48965b68be3ba00f7f7f45f4","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-27T16:28:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"chore: trailing space","shortMessageHtmlLink":"chore: trailing space"}},{"before":"3963475d2293fdd0a1bc019059103a06a95e2d2c","after":"32046d43e378b4403e163b9cfc230aa91c343436","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-18T13:52:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"chore: missing whitespace after comment block","shortMessageHtmlLink":"chore: missing whitespace after comment block"}},{"before":"23187ce118dbdff718f866597dc69631ca73243b","after":"3963475d2293fdd0a1bc019059103a06a95e2d2c","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-18T13:48:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"chore: document the meaning of CHAR","shortMessageHtmlLink":"chore: document the meaning of CHAR"}},{"before":"adf50e45f941cc65a4a17e6e1b24e4da62b601f4","after":"23187ce118dbdff718f866597dc69631ca73243b","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-17T21:55:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"chore: reorder regexp per review comment\n\nThe regexp should be in the same order as the RFC grammar, for ease\nof checking.","shortMessageHtmlLink":"chore: reorder regexp per review comment"}},{"before":"b45a9ed44dc8234f0c7871e173571f6fb8fb0266","after":"adf50e45f941cc65a4a17e6e1b24e4da62b601f4","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-17T19:23:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"chore: removing some extra spaces","shortMessageHtmlLink":"chore: removing some extra spaces"}},{"before":null,"after":"b45a9ed44dc8234f0c7871e173571f6fb8fb0266","ref":"refs/heads/bewins/regexps","pushedAt":"2024-07-17T19:16:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"bewinsnw","name":"Brian Ewins","path":"/bewinsnw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/119598239?s=80&v=4"},"commit":{"message":"fix: narrow the validation cookies to match RFC6265\n\nfixes #165. Previously, validation on serialization used the field-content\nregexp from RFC7230 to perform all checks. However, that is the regexp\nfor the cookie header as a whole, but each individual part of a cookie\nhas a tighter restriction.\n\nIn the bug report #165 I demonstrated that whitespace in names and values\nwas invalid but allowed by the field-content pattern. In this code I\nstarted by adding tests for those two cases, then added the expressions\nderived from the RFC; the relevant portions of the RFC have been inlined\nas comments.\n\nRemoving the field-content regexp unearthed that as well as those two\nit was being used to validate domain names and paths. Paths are fairly\nunrestricted (being any ascii character except control characters and\nsemicolon) but the code was wrong here too - it allowed all 8-bit characters\nnot just 7-bit characters.\n\nDomain names have a well recognised pattern, there are only a couple of\ngotchas: RFC6265 explicitly says RFC1123 applies, so the leading character\nof a label is allowed to be a digit; and while I wondered for a moment\nif this should allow things like [::1] the domain matching section of\nhttps://datatracker.ietf.org/doc/html/rfc6265#section-5.1.3\nteaches that domain values are _not_ ip addresses.","shortMessageHtmlLink":"fix: narrow the validation cookies to match RFC6265"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0yN1QxNjoyODozMC4wMDAwMDBazwAAAASKyrKW","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0yN1QxNjoyODozMC4wMDAwMDBazwAAAASKyrKW","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0xN1QxOToxNjozNy4wMDAwMDBazwAAAASCMDB7"}},"title":"Activity · bewinsnw/cookie"}