Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge queue attempt 1 #351

Closed

Conversation

geekingfrog
Copy link
Contributor

@geekingfrog geekingfrog commented Jul 5, 2024

This is an attempt to create a merge queue to reduce the amount of work required to deploy and test various branches on the integration server.
The assumption is that everything will be fine and we can merge all of that at once, which hopefully reduce the burden on the people having to deploy&test.

Here's a summary of what's in this bundle and a checklist of stuff to check:

#330 better restriction titles

!boss me
$rename 8v8 Glitters Noobs
$setratinglevels 1 20
  • The lobby should show "[…] | Rating: 1-20"

#331 some more icon fixes

Shouldn't need to test anything, worst case, an icon doesn't show

#333 Improvement to whoami and whois commands

  • connect and send command $whoami and $whois, should display chevron level

#339 Prevent renaming accounts when they start with "[Host"

  • attempt to rename an account as "[Host]hello" and make sure it doesn't work

#308 make CI great again

Ignore many tests and add a few more dialyzer ignores

  • the CI should pass

#291 move cache initialisation under supervision trees

There should be no functional change.

  • the server starts alright
  • can login, join a lobby, play a match and exit and nothing explodes server side (this is more a sanity check than anything else)

geekingfrog and others added 30 commits May 20, 2024 19:40
Mostly on the server dashboard page
Because that's where they should live.
And also, because there are some reference to ExUnit in this file now,
that is only available during tests. Putting the test_lib file under
test makes dialyzer happier since it's on the correct compiler path.
@geekingfrog geekingfrog marked this pull request as ready for review July 6, 2024 17:16
@geekingfrog
Copy link
Contributor Author

Closing it as all but one of the mentioned PR have been merged.

@geekingfrog geekingfrog deleted the merge-queue-attempt-1 branch July 10, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants