Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes to PCH #213

Merged
merged 3 commits into from
Mar 11, 2023
Merged

A few fixes to PCH #213

merged 3 commits into from
Mar 11, 2023

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Feb 20, 2023

  • MSVC: Fix PCH include directory
  • MSVC: Pass only PCH-header name to -Yu
  • GCC: Pass -ftemplate-depth-xxx when building PCH
  • Test: Invoke b2 with .exe suffix on Windows

Fixes boostorg/boost#711

@grafikrobot grafikrobot merged commit 633bc32 into bfgroup:main Mar 11, 2023
grafikrobot pushed a commit that referenced this pull request Mar 11, 2023
* Test: Invoke b2 with .exe suffix on Windows

* GCC: Pass -ftemplate-depth-xxx when building PCH

* MSVC: Fix PCH include directory and pass only PCH-header name to -Yu

Apparently `[ $(pch-header).path ]` gives the wrong path to the header.
@Kojoley Kojoley deleted the few-fixes branch April 2, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with precompiled headers fails under MSVC if PCH is not included
2 participants