Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Re)move sidecars with no data files #461

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Aug 6, 2024

Detected by bids-standard/bids-validator#2057.

@Remi-Gau I think you're clearer on the processes here. Is there a process for fixing upstream?

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Aug 6, 2024

Is there a process for fixing upstream?

not really: several examples have started to diverge from their "source" data and AFAICR we always said this was fine, though as mentioned here it would be nice if the target data was on openneuro and "we" (bids maintainers and dataset curators) were given access to it.

effigies added a commit to effigies/bids-validator that referenced this pull request Aug 6, 2024
effigies added a commit to effigies/bids-validator that referenced this pull request Aug 7, 2024
@effigies
Copy link
Contributor Author

effigies commented Aug 7, 2024

Going to go ahead and merge, as these are invalid files.

@effigies effigies merged commit 4460013 into bids-standard:master Aug 7, 2024
10 checks passed
@effigies effigies deleted the fix/unused_sidecars branch August 7, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants