Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BEP022 - Magnetic Resonance Spectroscopy #1377

Merged
merged 111 commits into from
Aug 26, 2024
Merged

[ENH] BEP022 - Magnetic Resonance Spectroscopy #1377

merged 111 commits into from
Aug 26, 2024

Commits on Oct 25, 2022

  1. First commit of bep022 into BIDS

    Adding and changing files to introduce MRS to the BIDS specification.
    markmikkelsen committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    fc31bac View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. More additions for bep022

    - Added future publication ref in 01-introduction.md
    - Added table of MRS sequences
    - Starting to add new details for the MRS JSON sidecar
    - Added MRS-MRI correspondence in Appendix
    - Added volume as a new entity
    - Changed order of MRS suffixes in src/schema/rulesfiles/raw/mrs.yaml
    markmikkelsen committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    3f7b06f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Configuration menu
    Copy the full SHA
    04541ec View commit details
    Browse the repository at this point in the history
  2. Further updates

    markmikkelsen committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    7a8a3af View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    2a644aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eed04ce View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Minor update

    markmikkelsen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    505a75f View commit details
    Browse the repository at this point in the history
  2. Spelling correction

    markmikkelsen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    dc65a36 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Update contributors.md

    markmikkelsen committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1979532 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Some minor edits

    markmikkelsen committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    81b057b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6b3f33 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Configuration menu
    Copy the full SHA
    199477d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8556305 View commit details
    Browse the repository at this point in the history
  3. Table style correction

    markmikkelsen committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    44bb58f View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Configuration menu
    Copy the full SHA
    b9ac19e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Configuration menu
    Copy the full SHA
    64c4ec6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3590535 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8e1fd6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c4b066b View commit details
    Browse the repository at this point in the history
  5. FIX: Macro formatting

    effigies committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    ba832d2 View commit details
    Browse the repository at this point in the history
  6. FIX: More numeric prefixes

    effigies committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    1fa4ab0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    ea2535b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1f2ca2 View commit details
    Browse the repository at this point in the history
  3. Update src/schema/rules/sidecars/mrs.yaml

    Change `NumberOfTransients` to be recommended for SVS and unloc data only; optional otherwise.
    
    Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
    markmikkelsen and effigies committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    28b746e View commit details
    Browse the repository at this point in the history
  4. Update mrs.yaml

    markmikkelsen committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c25573e View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Configuration menu
    Copy the full SHA
    57b21d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    8b49f2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96da97d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    3f83bdc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08201f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    3b8c4d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cea50ab View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8fff124 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    50b53e6 View commit details
    Browse the repository at this point in the history
  2. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    983b7c2 View commit details
    Browse the repository at this point in the history
  3. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5f619bc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    354215a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d8a1256 View commit details
    Browse the repository at this point in the history
  2. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    36346bc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec2e79e View commit details
    Browse the repository at this point in the history
  4. Update src/modality-specific-files/magnetic-resonance-spectroscopy.md

    Co-authored-by: Julia Guiomar Niso Galán <guiomar.niso@ctb.upm.es>
    markmikkelsen and guiomar committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    90ff238 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    35255f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    d48ca36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3888164 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    4b8d663 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f347f90 View commit details
    Browse the repository at this point in the history
  3. Update mrs.yaml

    markmikkelsen committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    aa90b54 View commit details
    Browse the repository at this point in the history
  4. Update entities.yaml

    markmikkelsen committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    13243f4 View commit details
    Browse the repository at this point in the history
  5. Further updates

    markmikkelsen committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    51a583f View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    ff370d7 View commit details
    Browse the repository at this point in the history
  2. Update contributors.md

    markmikkelsen committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f9b1eef View commit details
    Browse the repository at this point in the history
  3. Revert "Update contributors.md"

    This reverts commit f9b1eef.
    markmikkelsen committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    43ed253 View commit details
    Browse the repository at this point in the history
  4. Revert "Update contributors.md"

    This reverts commit f9b1eef.
    markmikkelsen committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    04c0c0d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b29d61a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    873fd79 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    1cae28a View commit details
    Browse the repository at this point in the history
  2. Update magnetic-resonance-spectroscopy.md

    Add Mkdocs admonition to example datasets paragraph
    markmikkelsen committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    22c7dd9 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    e75c74e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4772d83 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    248de47 View commit details
    Browse the repository at this point in the history
  4. Update magnetic-resonance-spectroscopy.md

    Adding metabolite-cycled spectroscopy to MRS sequences
    markmikkelsen committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b52b725 View commit details
    Browse the repository at this point in the history
  5. Update mrs.yaml

    markmikkelsen committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    37620c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    25c1ed2 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Update magnetic-resonance-spectroscopy.md

    - Cosmetic edits
    markmikkelsen committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    704844c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1766 from markmikkelsen/bep022

    Update magnetic-resonance-spectroscopy.md
    markmikkelsen committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    72e3c43 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    28d41ad View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Cleaning up language

    markmikkelsen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    836d01b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1776 from markmikkelsen/bep022

    Cleaning up language
    markmikkelsen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    32f78d4 View commit details
    Browse the repository at this point in the history
  3. Update mrs.yaml

    - Reorder MRS fields to coincide with (now) shared MRI fields
    markmikkelsen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    326a870 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20b2eaa View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1777 from markmikkelsen/bep022

    Update mrs.yaml
    markmikkelsen committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    ef6ff0e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    5232fef View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Apply suggestions from code review

    Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
    markmikkelsen and effigies committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    c00f360 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Configuration menu
    Copy the full SHA
    5796357 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Update magnetic-resonance-spectroscopy.md

    - Add NIfTI paper DOI
    markmikkelsen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7b00ba3 View commit details
    Browse the repository at this point in the history
  2. Update magnetic-resonance-spectroscopy.md

    - Fix table at lines 69-74
    markmikkelsen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e1c1d18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c86f000 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    a50eb8f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    87dcfbf View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    2ac36c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    f2612f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    b117050 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Update mrs.yaml

    - Change 'EditTarget', 'EditPulse', and 'EditCondition' to 'optional'
    markmikkelsen committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5eb0b5b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Update src/schema/objects/metadata.yaml

    Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
    markmikkelsen and effigies committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f024d8e View commit details
    Browse the repository at this point in the history
  2. Update magnetic-resonance-spectroscopy.md

    - Change "MRS-specific" to "MRS-relevant"
    markmikkelsen committed May 2, 2024
    Configuration menu
    Copy the full SHA
    defe06b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8a4534 View commit details
    Browse the repository at this point in the history
  4. Update fields for MRS

    markmikkelsen committed May 2, 2024
    Configuration menu
    Copy the full SHA
    44f5e63 View commit details
    Browse the repository at this point in the history
  5. Update metadata.yaml

    - Minor grammar change
    markmikkelsen committed May 2, 2024
    Configuration menu
    Copy the full SHA
    533194e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Some further changes

    - Reordered recommended MRS-relevant fields
    - Some rearranging of src/schema/rules/sidecars/mrs.yaml
    markmikkelsen committed May 8, 2024
    Configuration menu
    Copy the full SHA
    30aab9a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    abd9025 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    1e0e067 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    7016238 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Update metadata.yaml

    - Spelling correction
    markmikkelsen committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2c969bb View commit details
    Browse the repository at this point in the history
  2. Update src/schema/objects/metadata.yaml

    Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
    markmikkelsen and effigies committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8fc41ea View commit details
    Browse the repository at this point in the history
  3. Update src/schema/objects/metadata.yaml

    Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
    markmikkelsen and effigies committed May 29, 2024
    Configuration menu
    Copy the full SHA
    9116def View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    40bae63 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    0b03476 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6e3f72 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    899e6ec View commit details
    Browse the repository at this point in the history
  4. Split conditional matrices in schema, combine in doc

    This implements the following agreed upon suggestions:
    
    * Set InversionTime to recommended if `inv` entity is present.
      (`entities.inversion`)
    * Move to RepetitionTime and VolumeTiming, rather than RepetitionTime
      as an array in the variable-timing case.
    * ReferenceSignal should be uniformly recommended.
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9dabf8e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    07d2ec8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0181150 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83c6f3e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Configuration menu
    Copy the full SHA
    1d5e089 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1830 from effigies/schema/mrs_header

    [SCHEMA] MRS schema updates
    markmikkelsen committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    e1ae75e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70bc2ca View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    ae8bd87 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Update src/schema/rules/sidecars/func.yaml

    Co-authored-by: Taylor Salo <salot@pennmedicine.upenn.edu>
    markmikkelsen and tsalo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    b0bea61 View commit details
    Browse the repository at this point in the history
  2. FIX: Add MRS events files, restrict sidecar metadata checks to data f…

    …iles (#1875)
    
    * FIX: Add MRS events files, restrict sidecar metadata checks to data files
    
    * FIX: Do not limit suffixes for filename template
    effigies committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1ef102b View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    b110114 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    64f31ab View commit details
    Browse the repository at this point in the history