Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] BEP022 - Magnetic Resonance Spectroscopy #1377

Merged
merged 111 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 107 commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
fc31bac
First commit of bep022 into BIDS
markmikkelsen Oct 25, 2022
3f7b06f
More additions for bep022
markmikkelsen Oct 28, 2022
04541ec
Further updates for bep022
markmikkelsen Dec 7, 2022
7a8a3af
Further updates
markmikkelsen Dec 7, 2022
2a644aa
Adding more metadata to MRS-specific fields
markmikkelsen Dec 8, 2022
eed04ce
Finalizing additions for bep022
markmikkelsen Dec 8, 2022
505a75f
Minor update
markmikkelsen Dec 9, 2022
dc65a36
Spelling correction
markmikkelsen Dec 9, 2022
1979532
Update contributors.md
markmikkelsen Jan 5, 2023
81b057b
Some minor edits
markmikkelsen Jan 6, 2023
c6b3f33
Merge remote-tracking branch 'upstream/master' into bep022
effigies Jan 6, 2023
199477d
Some minor changes and fixes to automatic checks.
markmikkelsen Jan 10, 2023
8556305
Merge branch 'bep022' of https://github.com/markmikkelsen/bids-specif…
markmikkelsen Jan 10, 2023
44bb58f
Table style correction
markmikkelsen Jan 10, 2023
b9ac19e
Further corrections to fix check failures
markmikkelsen Jan 11, 2023
64c4ec6
Further corrections to fix check failures (2)
markmikkelsen Jan 12, 2023
3590535
DOC: Remove 02- from common principles URL, drop DEPRECATED option.
effigies Jan 12, 2023
a8e1fd6
Merge remote-tracking branch 'upstream/master' into bep022
effigies Jan 12, 2023
c4b066b
FIX: Remove 04- and 01- from MRI links
effigies Jan 12, 2023
ba832d2
FIX: Macro formatting
effigies Jan 12, 2023
1fa4ab0
FIX: More numeric prefixes
effigies Jan 12, 2023
ea2535b
Remove DEPRECATED functionalities
markmikkelsen Jan 27, 2023
b1f2ca2
Change URL to NIfTI-MRS paper
markmikkelsen Jan 27, 2023
28b746e
Update src/schema/rules/sidecars/mrs.yaml
markmikkelsen Jan 27, 2023
c25573e
Update mrs.yaml
markmikkelsen Jan 27, 2023
57b21d7
Update README.md; minor cosmetic change
markmikkelsen Feb 7, 2023
8b49f2b
Merge branch 'master' into bep022
Remi-Gau Aug 24, 2023
96da97d
Update src/schema/objects/metadata.yaml
Remi-Gau Aug 24, 2023
3f83bdc
Merge branch 'master' into bep022
Remi-Gau Sep 7, 2023
08201f1
Merge pull request #1 from bids-standard/bep022
markmikkelsen Sep 7, 2023
3b8c4d5
Merge branch 'master' into bep022
effigies Nov 27, 2023
cea50ab
STY: Cleanup apparent merge artifacts
effigies Nov 27, 2023
8fff124
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen Nov 27, 2023
50b53e6
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 19, 2023
983b7c2
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 19, 2023
5f619bc
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 19, 2023
354215a
Merge branch 'bep022' of https://github.com/markmikkelsen/bids-specif…
markmikkelsen Dec 19, 2023
d8a1256
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 20, 2023
36346bc
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 20, 2023
ec2e79e
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen Dec 20, 2023
90ff238
Update src/modality-specific-files/magnetic-resonance-spectroscopy.md
markmikkelsen Dec 20, 2023
35255f6
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen Dec 21, 2023
d48ca36
Merge branch 'master' into bep022
Remi-Gau Feb 28, 2024
3888164
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen Feb 28, 2024
4b8d663
Merge branch 'master' into bep022
effigies Feb 29, 2024
f347f90
Merge branch 'bep022' of https://github.com/markmikkelsen/bids-specif…
markmikkelsen Feb 29, 2024
aa90b54
Update mrs.yaml
markmikkelsen Feb 29, 2024
13243f4
Update entities.yaml
markmikkelsen Feb 29, 2024
51a583f
Further updates
markmikkelsen Feb 29, 2024
ff370d7
Update the `MRAcquisitionType` schema
markmikkelsen Mar 1, 2024
f9b1eef
Update contributors.md
markmikkelsen Mar 1, 2024
43ed253
Revert "Update contributors.md"
markmikkelsen Mar 1, 2024
04c0c0d
Revert "Update contributors.md"
markmikkelsen Mar 1, 2024
b29d61a
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen Mar 1, 2024
873fd79
Add a section about MRS-MRI correspondence
markmikkelsen Mar 1, 2024
1cae28a
Merge branch 'master' into bep022
markmikkelsen Mar 21, 2024
22c7dd9
Update magnetic-resonance-spectroscopy.md
markmikkelsen Mar 21, 2024
e75c74e
Change tissue description requirement levels in MRS to optional
markmikkelsen Mar 28, 2024
4772d83
Update MRS-MRI correspondence
markmikkelsen Mar 28, 2024
248de47
Change suffix `ref` to `mrsref`
markmikkelsen Mar 28, 2024
b52b725
Update magnetic-resonance-spectroscopy.md
markmikkelsen Mar 28, 2024
37620c9
Update mrs.yaml
markmikkelsen Mar 28, 2024
25c1ed2
Merge branch 'master' into bep022
markmikkelsen Apr 8, 2024
704844c
Update magnetic-resonance-spectroscopy.md
markmikkelsen Apr 9, 2024
72e3c43
Merge pull request #1766 from markmikkelsen/bep022
markmikkelsen Apr 9, 2024
28d41ad
Merge branch 'master' into bep022
effigies Apr 11, 2024
836d01b
Cleaning up language
markmikkelsen Apr 13, 2024
32f78d4
Merge pull request #1776 from markmikkelsen/bep022
markmikkelsen Apr 13, 2024
326a870
Update mrs.yaml
markmikkelsen Apr 13, 2024
20b2eaa
Merge branch 'bep022' into bep022
markmikkelsen Apr 13, 2024
ef6ff0e
Merge pull request #1777 from markmikkelsen/bep022
markmikkelsen Apr 13, 2024
5232fef
Merge branch 'master' into bep022
markmikkelsen Apr 16, 2024
c00f360
Apply suggestions from code review
markmikkelsen Apr 20, 2024
5796357
Merge branch 'master' into bep022
markmikkelsen Apr 21, 2024
7b00ba3
Update magnetic-resonance-spectroscopy.md
markmikkelsen Apr 22, 2024
e1c1d18
Update magnetic-resonance-spectroscopy.md
markmikkelsen Apr 22, 2024
c86f000
Merge branch 'master' into bep022
markmikkelsen Apr 22, 2024
a50eb8f
Merge branch 'master' into bep022
markmikkelsen Apr 24, 2024
87dcfbf
Merge branch 'master' into bep022
markmikkelsen Apr 25, 2024
2ac36c7
Merge branch 'master' into bep022
markmikkelsen Apr 26, 2024
f2612f6
Merge branch 'master' into bep022
markmikkelsen Apr 27, 2024
b117050
Merge branch 'master' into bep022
markmikkelsen Apr 30, 2024
5eb0b5b
Update `mrs.yaml`
markmikkelsen May 1, 2024
f024d8e
Update src/schema/objects/metadata.yaml
markmikkelsen May 2, 2024
defe06b
Update magnetic-resonance-spectroscopy.md
markmikkelsen May 2, 2024
f8a4534
Set `OuterVolumeSuppression` as `optional`
markmikkelsen May 2, 2024
44f5e63
Update fields for MRS
markmikkelsen May 2, 2024
533194e
Update metadata.yaml
markmikkelsen May 2, 2024
30aab9a
Some further changes
markmikkelsen May 8, 2024
abd9025
Merge branch 'master' into bep022
markmikkelsen May 16, 2024
1e0e067
Merge branch 'master' into bep022
markmikkelsen May 21, 2024
7016238
Merge branch 'master' into bep022
markmikkelsen May 28, 2024
2c969bb
Update metadata.yaml
markmikkelsen May 29, 2024
8fc41ea
Update src/schema/objects/metadata.yaml
markmikkelsen May 29, 2024
9116def
Update src/schema/objects/metadata.yaml
markmikkelsen May 29, 2024
40bae63
Merge branch 'bids-standard:bep022' into bep022
markmikkelsen May 29, 2024
0b03476
Merge branch 'master' into bep022
markmikkelsen May 31, 2024
f6e3f72
SCHEMA: Add nifti_header.mrs to context
effigies May 21, 2024
899e6ec
SCHEMA: Add check for consistency between MRS header and sidecar
effigies May 21, 2024
9dabf8e
Split conditional matrices in schema, combine in doc
effigies May 29, 2024
07d2ec8
Make BodyPart(Details) required if voi entity is present
effigies May 29, 2024
0181150
feat(checks): Add check to ensure MatrixSize and nifti_header.dim are…
effigies May 29, 2024
83c6f3e
fix(checks): Use non-trivial expressions for selectors
effigies May 30, 2024
1d5e089
Uncombine required/recommended/optional fields
effigies Jun 1, 2024
e1ae75e
Merge pull request #1830 from effigies/schema/mrs_header
markmikkelsen Jun 1, 2024
70bc2ca
Merge branch 'master' into bep022
markmikkelsen Jun 1, 2024
ae8bd87
Merge branch 'master' into bep022
effigies Jul 24, 2024
b0bea61
Update src/schema/rules/sidecars/func.yaml
markmikkelsen Jul 25, 2024
1ef102b
FIX: Add MRS events files, restrict sidecar metadata checks to data f…
effigies Jul 25, 2024
b110114
Merge branch 'master' into bep022
effigies Aug 7, 2024
64f31ab
Merge branch 'master' into bep022
effigies Aug 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ BIDS currently supports the following data modalities with more to come in the f
- microscopy
- NIRS
- motion
- MRS

# Formatting your data with BIDS

Expand Down
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ nav:
- Microscopy: modality-specific-files/microscopy.md
- Near-Infrared Spectroscopy: modality-specific-files/near-infrared-spectroscopy.md
- Motion: modality-specific-files/motion.md
- Magnetic Resonance Spectroscopy: modality-specific-files/magnetic-resonance-spectroscopy.md
- Derivatives:
- BIDS Derivatives: derivatives/introduction.md
- Common data types and metadata: derivatives/common-data-types.md
Expand Down
7 changes: 7 additions & 0 deletions src/appendices/cross-modality-correspondence.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,10 @@ The reason for this is that the MRI needs to be corrected for nonlinear gradient
in order to fit the accompanying PET scans for co-registration
(Knudsen et al. 2020, [doi:10.1177/0271678X20905433](https://doi.org/10.1177/0271678X20905433);
Norgaard et al. 2019, [doi:10.1016/j.neuroimage.2019.05.055](https://doi.org/10.1016/j.neuroimage.2019.05.055)).

## MRS-MRI correspondence

It is typical to acquire high-resolution 3D anatomical MR images alongside MRS data for
voxel/slab placement, co-registration, and partial-volume tissue correction of metabolite concentrations.
To avoid incorrectly matching an MRS dataset with a corresponding anatomical MR image,
it is RECOMMENDED that the field `AnatomicalImage` be included in the MRS sidecar JSON files.
4 changes: 4 additions & 0 deletions src/introduction.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ For example:
PsyArXiv.
[doi:10.31234/osf.io/w6z79](https://doi.org/10.31234/osf.io/w6z79)

#### MRS

- (publication forthcoming)

### Research Resource Identifier (RRID)

BIDS has also a
Expand Down
260 changes: 260 additions & 0 deletions src/modality-specific-files/magnetic-resonance-spectroscopy.md

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/schema/meta/context.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,10 @@ properties:
name: 'sform code'
description: 'Use of the affine fields.'
type: integer
mrs:
name: 'NIfTI-MRS extension'
description: 'NIfTI-MRS JSON fields'
type: object
ome:
name: 'Open Microscopy Environment fields'
description: 'Parsed contents of OME-XML header, which may be found in OME-TIFF or OME-ZARR files'
Expand Down
3 changes: 3 additions & 0 deletions src/schema/objects/common_principles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ data_type:
12. `nirs` (near infrared spectroscopy)

13. `motion` (motion)

14. `mrs` (magnetic resonance spectroscopy)

dataset:
display_name: Dataset
description: |
Expand Down
4 changes: 4 additions & 0 deletions src/schema/objects/datatypes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ motion:
value: motion
display_name: Motion
description: Motion data from a tracking system
mrs:
value: mrs
display_name: Magnetic Resonance Spectroscopy
description: Magnetic resonance spectroscopy data
perf:
value: perf
display_name: Perfusion imaging
Expand Down
23 changes: 22 additions & 1 deletion src/schema/objects/entities.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,17 @@ mtransfer:
enum:
- $ref: objects.enums.on__mtransfer.value
- $ref: objects.enums.off__mtransfer.value
nucleus:
name: nuc
display_name: Nucleus
description: |
The `nuc-<label>` entity can be used to distinguish acquisitions tuned
to detect different nuclei.
The label is the name of the nucleus or nuclei, which corresponds to DICOM Tag `0018, 9100`.
If present in the filename, `"ResonantNucleus"` MUST also be included in
the associated metadata.
type: string
format: label
part:
name: part
display_name: Part
Expand Down Expand Up @@ -408,9 +419,19 @@ tracer:
Please note that the `<label>` does not need to match the actual value of the field.
type: string
format: label
volume:
name: voi
display_name: Volume of Interest
description: |
The `voi-<label>` entity can be used to distinguish acquisitions localized to different regions.
The label SHOULD be the name of the body region or part scanned.
If used, the fields `"BodyPart"` and `"BodyPartDetails"` MUST be defined in the JSON file.
`BodyPartDetailsOntology` is OPTIONAL to also include.
type: string
format: label
tracksys:
name: tracksys
display_name: Tracking system
display_name: Tracking System
description: |
The `tracksys-<label>` entity can be used as a key-value pair
to label *_motion.tsv and *_motion.json files.
Expand Down
5 changes: 5 additions & 0 deletions src/schema/objects/enums.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ Absent:
display_name: Absent
description: |
No specific M0 information is present.
OneD:
value: 1D
display_name: One-dimensional
description: |
One-dimensional MR acquisition.
TwoD:
value: 2D
display_name: Two-dimensional
Expand Down
Loading