From be6936d95371291d637eedca8902d24c4a836537 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=80=9Cbc-yevhenii-buliuk=E2=80=9D?= <“yevhenii.buliuk@bigcommerce.com”> Date: Tue, 1 Jun 2021 17:03:28 +0300 Subject: [PATCH] fix(storefront): BCTHEME-906 Hide prices for aria-label and data-product-price attributes if set to Hidden for guests --- CHANGELOG.md | 1 + lang/en.json | 1 + .../components/common/login-for-pricing.html | 2 +- templates/components/common/navigation.html | 4 ++- templates/components/products/card.html | 27 ++++++++++++++----- templates/components/products/list-item.html | 25 ++++++++++++++--- .../components/products/product-view.html | 13 ++++++++- 7 files changed, 61 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bac41c1743..d798755d29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Changelog ## Draft +- Hide prices for aria-label and data-product-price attributes if set to "Hidden for guests". Hide currency selection for non-logged in users. [#2131](https://github.com/bigcommerce/cornerstone/pull/2131) - Added settings for payment banners. [#2021](https://github.com/bigcommerce/cornerstone/pull/2021) - Use https:// for schema markup. [#2039](https://github.com/bigcommerce/cornerstone/pull/2039) - Update focus tooltip styles contrast to achieve accessibility AA Complaince. [#2047](https://github.com/bigcommerce/cornerstone/pull/2047) diff --git a/lang/en.json b/lang/en.json index 70143f39fa..2141b10177 100755 --- a/lang/en.json +++ b/lang/en.json @@ -159,6 +159,7 @@ "change": "Change", "sign_up": "Register", "login": "Sign in", + "login_for_pricing": "Log in for pricing", "logout": "Sign out", "account": "Account", "cart": "Cart", diff --git a/templates/components/common/login-for-pricing.html b/templates/components/common/login-for-pricing.html index fc49b1162a..ae128c776b 100644 --- a/templates/components/common/login-for-pricing.html +++ b/templates/components/common/login-for-pricing.html @@ -1 +1 @@ -

Log in for pricing

\ No newline at end of file +

{{lang 'common.login_for_pricing'}}

diff --git a/templates/components/common/navigation.html b/templates/components/common/navigation.html index dde9d24005..99b20718d7 100644 --- a/templates/components/common/navigation.html +++ b/templates/components/common/navigation.html @@ -1,5 +1,7 @@