From e3e02e0069a3ca7b932703d79bf2fb981de57922 Mon Sep 17 00:00:00 2001 From: yurytut1993 <66325265+yurytut1993@users.noreply.github.com> Date: Wed, 21 Oct 2020 13:56:22 +0300 Subject: [PATCH] BCTHEME-190 Content should not scroll in two directions when zoomed (#1853) Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com> --- CHANGELOG.md | 4 ++-- .../components/stencil/productView/_productView.scss | 9 ++++++++- templates/components/products/product-view.html | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 97b35c6284..90418ee76e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,9 +1,9 @@ # Changelog ## Draft +- Content should not scroll in two directions when zoomed. [#1853](https://github.com/bigcommerce/cornerstone/pull/1853) - Notification of number of products not announced. [#1845](https://github.com/bigcommerce/cornerstone/pull/1845) -- Quick search query param needs to be fixed while navigating to search page. [#230](https://jira.bigcommerce.com/browse/BCTHEME-230) -- Quick search query param needs to be fixed while navigating to search page. [#230](https://jira.bigcommerce.com/browse/BCTHEME-230) +- Quick search query param needs to be fixed while navigating to search page. [#1832](https://github.com/bigcommerce/cornerstone/pull/1832) - Zooming and scaling must not be disabled. [#1843](https://github.com/bigcommerce/cornerstone/pull/1843) - Options on change modal need focus border. [#1839](https://github.com/bigcommerce/cornerstone/pull/1839) - Product cards should link to products. [#1842](https://github.com/bigcommerce/cornerstone/pull/1842) diff --git a/assets/scss/components/stencil/productView/_productView.scss b/assets/scss/components/stencil/productView/_productView.scss index ac0dcfd3ff..326aed5aef 100644 --- a/assets/scss/components/stencil/productView/_productView.scss +++ b/assets/scss/components/stencil/productView/_productView.scss @@ -119,10 +119,17 @@ // Details // ----------------------------------------------------------------------------- +// +// 1. for Androind Chrome and IE with zoom horizontal scroll fix +// +// ----------------------------------------------------------------------------- .productView-details { padding-bottom: spacing("single") + spacing("third"); - overflow: hidden; // for Androind Chrome horizontal scroll fix + + &.product-options { + overflow: hidden; // 1 + } } diff --git a/templates/components/products/product-view.html b/templates/components/products/product-view.html index aca974123b..33778da258 100644 --- a/templates/components/products/product-view.html +++ b/templates/components/products/product-view.html @@ -215,7 +215,7 @@

-
+
{{#if product.release_date }}

{{product.release_date}}