Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH upload-artifact action to v4 to fix build #2494

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

bookernath
Copy link
Contributor

@bookernath bookernath commented Oct 19, 2024

What?

Fix the GH action that builds Cornerstone by bumping upload-artifact:

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

While I was doing this, I improved the action in other ways:

  • Update matrix strategy
  • Use modern node versions (18/20)
  • Improve artifact naming

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

@bookernath bookernath force-pushed the fix-gh-actions branch 8 times, most recently from 78380c8 to 2a7b993 Compare October 19, 2024 02:15
- Bump to node 18/20
- Use better filenames
@bookernath bookernath requested a review from a team October 19, 2024 02:17
Copy link

@becomevocal becomevocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bookernath bookernath merged commit f51634a into master Oct 19, 2024
4 checks passed
@bookernath bookernath deleted the fix-gh-actions branch October 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants