-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior change in price_range.max and .min in product.getById #208
Comments
Here's a way this can be tested: In a stencil theme, we need a template for stencil utils to show the data it's returning. Don't forget to add to the top of the file |
Working with one support agent they’ve found that the issue is the min/max price is based on the default product options. It would be great if it could be changed so that when asking the question of a product, the min max answer is truly with respect to that product and not its default selection. |
Hi @bobghkuranda, stencil-utils library is a frontend layer between theme and API. We are going to create a ticket and investigate a potential issue. |
Hi, for some time we've called product.getById for 2 products to render the price ranges for the 2 products compared in a table at the bottom of this page.
https://kuranda.com/dog-breeds/airedale-terrier
Somewhere along the way the behavior has changed where the max price returned is no longer correct for both and the min price is wrong for the second. You can see the correct prices ranges by taking a look at the first and third products on this page.
https://kuranda.com/dog-beds
I can confirm it's not an issue where my template is changing the value, if I look at the debug context for the data returned by the API call it shows the incorrect numbers as they render on the page. The only parameter I'm passing to the call besides the product ID is my custom template to render the response with.
Our products do have around 250 variants, and the true max price is found toward the end of that range assuming you sort by order of creating those variants. It's possible the change in behavior is that whatever happens on the API side with stencil utils is now capping the amount of variants it loads where before it loaded all of them. We are also on v2 product options if that makes a difference.
The text was updated successfully, but these errors were encountered: