Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic N5ImageLoader #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Generic N5ImageLoader #84

wants to merge 2 commits into from

Conversation

tischi
Copy link
Contributor

@tischi tischi commented Feb 6, 2020 •
edited
Loading

Hi @tpietzsch @axtimwalde ,

I am suggesting a modification to the N5ImageLoader such that it is not only used for N5FSReader, but can also be used with other N5Reader such as, e.g., the N5AmazonS3Reader.

@tischi tischi requested a review from tpietzsch February 6, 2020 11:03
@tischi
Copy link
Contributor Author

tischi commented Feb 6, 2020 •
edited
Loading

What is not nice are the getFile() and setFile() methods in N5ImageLoader. If those methods are only needed to generate the corresponding xml elements during saving, what about giving a Map<String, String> xmlTagToValue in the constructor of the N5ImageLoader and then having a method getXmlTagToValue(). This would then work for all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpietzsch tpietzsch Awaiting requested review from tpietzsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tischi