-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluguin not working on Angular Workspace #467
Comments
The Nx team may not provide stable compatibility with AngularCLI workspaces. See nrwl/nx#14413 (comment). They recommend using Angular CLI DevKit to make it run on Angular CLI workspaces. That put us in a difficult position; we need to support two workspaces in parallel to be fully compatible and stable with AngularCLI workspaces. That seems challenging due to the amount of work that it would require. |
@edbzn I would like to have your input on this problem. |
@dianjuar I agree, it's already hard to keep compatibility between different Nx versions (even minor versions), so keeping Angular CLI compatibility is very time-consuming and bug-prone. However it depends on your users, are they using more Nx or Angular CLI? If Angular CLI is important for your users you could point to an old ngx-deploy-npm version in your documentation that might still be compatible with Angular CLI, or even provide fixes/updates to your old branches that still run on Angular CLI, but it means managing two branches that run on different technologies, it's not ideal. |
I am still determining the percentage of users using this plugin in an Angular Workspace, but in a quick look, apparently, more users are using Nx. If the AngularCLI workspace users are low, I would consider deprecating AngularCLI Workspaces. For science and fun, I want to create a script based on the GitHub dependent list stats to determine the portion of users on each workspace. That would give an idea of the number of users that would be affected and if it's a good idea to deprecate the AngularCLI Workspaces compatibility. Recently I saw that the Nx Console is removing its compatibility with AngularCLI workspaces, so I don't see a bad idea doing the same. |
We can think about a potential plugin name change since the |
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including the fact that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding. close #467
We have decided to stop supporting Angular Workspaces and focus exclusively on Nx Workspaces. This decision is motivated by several factors, including the fact that the Nx Devkit no longer supports compatibility with Angular Workspaces. To offer support, we would have to create a second plugin that uses AngularDevkit under the hood, which would require considerable effort on the part of our maintainers. We want to focus on what brings the most value to our current users, and Nx Workspaces is the best way to do that. BREAKING CHANGE: As an alternative, maintainers suggest migrating your Angular Workspaces to Nx Workspaces if you want to use this plugin. A stand-alone approach to Nx workspaces is an option that you should consider. We apologize for any inconvenience this may cause and appreciate your understanding. close #467
We decided to remove on #454 the Angular E2E tests as required on the Publish CI Pipeline to unblock the issue.
This issue is to keep an eye on Nx for the fix to:
The text was updated successfully, but these errors were encountered: