Basic i18n support #239
Merged
Basic i18n support #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains 3 translatable strings, 1 of which is (possibly badly) translated to Spanish To extract default messages: npm run extract To compile translations: ./compile-langs.sh TODO: - add lint rules https://formatjs.io/docs/guides/develop#linter-installation - integrate with translation tooling https://formatjs.io/docs/getting-started/application-workflow#pipeline - translate more messages + numbers
vincepmartin
approved these changes
Jan 27, 2023
|
Tested locally ok for me in spanish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains 3 translatable strings, 1 of which ("Get directions") I translated to Spanish based on Wiktionary and it may be wrong.
The translation may be tested by adding
?locale=esto the end of the BikeHopper URL.To extract default messages:
To compile translations:
TODO:
Relevant to #238