Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeePassX - Generic application icon instead of the tray icons #173

Closed
aviskase opened this issue Aug 20, 2016 · 9 comments
Closed

KeePassX - Generic application icon instead of the tray icons #173

aviskase opened this issue Aug 20, 2016 · 9 comments
Assignees

Comments

@aviskase
Copy link

aviskase commented Aug 20, 2016

Hello! I found an issue #143 that should have fixed tray icons for KeePassX.
When I'm running hardcode-tray it seems to successfully fix them:

Welcome to the tray icons hardcoder fixer!
Your indicator icon size is : 22
Your current icon theme is : Numix-Circle
Svg to png functions are : Enabled
Applications will be fixed : All
1 - Apply
2 - Revert
Please choose: 1
Applying now..

...
Keepassx -- fixed using keepassx-indicator
Keepassx -- fixed using keepassx-locked

But nothing happens: tray icon is still generic application icon, not the ones committed in the numixproject/numix-icon-theme#1000
0821_997

@bilelmoussaoui bilelmoussaoui self-assigned this Aug 21, 2016
@bilelmoussaoui bilelmoussaoui added this to the v4.0 milestone Aug 21, 2016
@bilelmoussaoui
Copy link
Owner

Can you take a screenshot of the content of /usr/share/keepassx/icons? Also which version of Keepassx/Numix circle are you using?

@aviskase
Copy link
Author

Versions:

  • keepassx: 2.0.2-1.02eugenesanwily1
  • numix-icon-theme: 0.3+824201608071940ubuntu16.04.1
  • numix-icon-theme-circle: 2.0.3+5201608132046ubuntu16.04.1

And a screenshot:
0821_965

@bilelmoussaoui
Copy link
Owner

What happens if you change your theme from Numix-circle to Numix?

@andia89
Copy link
Collaborator

andia89 commented Aug 21, 2016

Looks like the icon is taken from circle instead of base. Might be another case for moving them to panel

@aviskase
Copy link
Author

What happens if you change your theme from Numix-circle to Numix?

Now it's plane keepassx icon.
0821_763

I'm beginning to think that there is something wrong with keepassx itself. Because it was mentioned in the #143 that there is standard keepassx-locked icon for tray --- but it never shows up regardless of theme / applying-reverting with harcode-tray.

@andia89
Copy link
Collaborator

andia89 commented Aug 21, 2016

Oh yeah, the poblem is that the app uses the same name for the app icon and for the icon in the tray. Thus the theme cannot provide both :( Nothing that can be done but changing this upstream I'm afraid

@aviskase
Copy link
Author

Thanks! I used your explanation and reported an issue to keepassx bug tracker. For those, who might be interested, link is https://dev.keepassx.org/issues/527
So this one could be closed.

@bilelmoussaoui
Copy link
Owner

Thanks for reporting it upstream! We had the same issue with other application on Numix theme. Can you please keep us updated if there's any modification in the future? :)

@aviskase
Copy link
Author

Yep, of course =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants