New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brpc c++ SDK 接口解析与 API 文档不一致 #70

Open

wasphin opened this issue Nov 25, 2020 · 1 comment

wasphin commented Nov 25, 2020

brpc 客户端部分使用 fetchs 批量获取实例，但解析响应部分与文档说明以及实际运行结果不一致，麻烦确认一下看是那边的问题。

API 文档
https://github.com/bilibili/discovery/blob/master/doc/api.md#%E6%89%B9%E9%87%8F%E8%8E%B7%E5%8F%96%E5%AE%9E%E4%BE%8Bfetchs

以及 brpc 源码

https://github.com/apache/incubator-brpc/blob/2aea69107891060eeb98ec7ce61f1a1a8f033ada/src/brpc/policy/discovery_naming_service.cpp#L390

https://github.com/apache/incubator-brpc/blob/2aea69107891060eeb98ec7ce61f1a1a8f033ada/test/brpc_naming_service_unittest.cpp#L467

wasphin mentioned this issue

Fix problem of fetching nodes from discovery naming service apache/brpc#1293

Open

Member

lintanghui commented Dec 4, 2020

这个我们兼容下，discovery的开源版本是只暴露了一个instances字段。内网版本为了兼容还保留了 zone_instances 字段用于做机房级别的区分

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment