Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Hi-Res support #71

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

JokerQyou
Copy link
Contributor

@JokerQyou JokerQyou commented Mar 4, 2023

  • 使用更新版本的 biliup 库(但不是master分支最新版)
  • 投稿时支持 Hi-Res 选项

目前的 Hi-Res 支持有些问题:

  • 仅初次投稿时可以勾选:因为 biliup 使用的是移动端 API,查询接口不会返回稿件的 lossless_music 字段。所以编辑稿件时,不能判断稿件是否勾选了 Hi-Res 选项。因此在编辑稿件时不会提交这个参数。

Closes #59, close #65.

@JokerQyou JokerQyou marked this pull request as draft March 4, 2023 04:50
@JokerQyou JokerQyou marked this pull request as ready for review March 4, 2023 05:13
@ForgQi
Copy link
Member

ForgQi commented Mar 4, 2023

大佬觉得没问题的话随时告诉我可以合并了

@JokerQyou JokerQyou force-pushed the feature/hi-res-option branch from c524564 to 91c1397 Compare March 4, 2023 17:16
@JokerQyou JokerQyou force-pushed the feature/hi-res-option branch from 91c1397 to b40d3c9 Compare March 4, 2023 17:35
@JokerQyou
Copy link
Contributor Author

我觉得 ok 了,如果看着没问题就合并吧。改了一下,如果编辑已有的稿件就不显示 hi-res 选项,只有在投稿新视频的时候可以勾选。

@JokerQyou JokerQyou changed the title [Draft] Basic Hi-Res support Basic Hi-Res support Mar 4, 2023
@ForgQi ForgQi merged commit fac71d4 into biliup:master Mar 5, 2023
@JokerQyou JokerQyou deleted the feature/hi-res-option branch March 7, 2023 01:34
@kimycai
Copy link

kimycai commented Mar 13, 2023

我觉得 ok 了,如果看着没问题就合并吧。改了一下,如果编辑已有的稿件就不显示 hi-res 选项,只有在投稿新视频的时候可以勾选。

确实,只要初次投稿时可以提交“HiRes”选项就可以,之后的追加或者编辑稿件无需修改“HiRes”选项,因为网页端也是灰色的不可修改的。

1toldyou added a commit that referenced this pull request May 24, 2024
* Update release.yml

* Basic Hi-Res support (#71)

* Fixed a bug where avatars could not be obtained (#98)

* UI Improvement and Update dependencies (#110)

* specify maxlength fot most of <input type="text"/>

* specify maxlength for most of <input type="text"/>

* specify maxlength for description

* use radio buttons to select video copyright type

* some refactoring and fix enter empty tag become

* allow all subdomains of bilibili's image/asset hosting

* enable devtools

* show current character count and limits

* limit length of video parts' title

* fix some Svelte a11y warning

* display the last submit time

* fix: "编辑成功: undefined"

* Feature: confirmation prompt on video P removal

* Feature: confirmation prompt on template removal

* No more max length

* Obvious text waring on inputs exceed limits instead

* create-tauri --beta

* gets better

* fix face not loading

* fix openConfigDir

* fix reading biliup/users

* upload still not working

* fix video part uploading

* cover image load but at weird position

* fix account switching

* fix cover image preview

* fix button group

* pre-release build

* update node version for CI

* update CI according to https://github.com/tauri-apps/tauri-action

* change tag name for pre-release.yml

* use actions/checkout@v4

* update pre-release.yml

* fix file drag and drop

* revert get_credential() as the optional parameter is not being used right now

* change back to lib.rs

* bump version to 0.5.0 (#112)

---------

Co-authored-by: ForgQi <34411314+ForgQi@users.noreply.github.com>
Co-authored-by: Joker_ <1465267+JokerQyou@users.noreply.github.com>
Co-authored-by: V Uethya <45510011+123485k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants