Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling for unexpected responses #580

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

rikroe
Copy link
Member

@rikroe rikroe commented Nov 11, 2023

Proposed change

Adds exception handling, hopefully fixing some of the issues our users see if the API doesn't respond with the correct vehicle details (e.g. tire status) or an additional, non-functioning vehicle in the account.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this library)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works.

@rikroe rikroe marked this pull request as draft November 11, 2023 21:44
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b267df3) 100.00% compared to head (cf50514) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1382      1397   +15     
=========================================
+ Hits          1382      1397   +15     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (?)
3.12 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
bimmer_connected/account.py 100.00% <100.00%> (ø)
bimmer_connected/vehicle/vehicle.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikroe rikroe marked this pull request as ready for review November 12, 2023 16:03
@rikroe rikroe requested a review from gerard33 November 12, 2023 16:03
@rikroe rikroe merged commit 4dfecef into bimmerconnected:master Nov 20, 2023
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants