Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): create language picker component #13

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

MSzalowski
Copy link

Description

  • Create a language picker component allowing to change language in the app.
  • Placed that component on sign-in screen.
  • Change setup of i18n for tests.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Change language using language picker component

Screenshot(s)

Simulator Screen Recording - iPhone 14 Pro - 2022-11-21 at 17 45 03

Test Configuration:

System:
    OS: macOS 13.0.1
    CPU: (8) arm64 Apple M1
    Memory: 79.61 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.16.0 - ~/.config/nvm/versions/node/v16.16.0/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.11.0 - ~/.config/nvm/versions/node/v16.16.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8609683
    Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.16.1 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.0.0 => 18.0.0
    react-native: 0.69.6 => 0.69.6
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Checklist:

  • Add correct label to your pull request
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@MSzalowski MSzalowski added the enhancement New feature or request label Nov 22, 2022
@MSzalowski MSzalowski marked this pull request as draft November 24, 2022 12:51
@MSzalowski MSzalowski force-pushed the feat/add-language-switch branch from e0a50ac to 43f9483 Compare November 24, 2022 18:24
@MateuszRostkowski MateuszRostkowski marked this pull request as ready for review December 1, 2022 18:29
@MateuszRostkowski MateuszRostkowski merged commit c4762e5 into main Dec 14, 2022
@MateuszRostkowski MateuszRostkowski deleted the feat/add-language-switch branch January 20, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants