Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop function kw #604

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Drop function kw #604

merged 2 commits into from
Jul 1, 2022

Conversation

mgree
Copy link
Collaborator

@mgree mgree commented Jul 1, 2022

A variety of scripts use the function keyword to define functions, which isn't POSIX. This PR drops that keyword from all scripts except for other/circular/sq.sh (I wanted to preserve that for evaluation).

It's not an issue per se---these scripts are already in bash, so there's no serious harm in having it there... except I was using those scripts to test the libdash bindings, and it broke them.

@mgree mgree changed the base branch from main to future July 1, 2022 01:02
amended to pass DCO

Signed-off-by: Michael Greenberg <michael.greenberg@stevens.edu>
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-20.04
Fri Jul 1 01:09:30 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-18.04
Fri Jul 1 01:09:34 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 3f5bc4f
Kernel= Linux 4.15.0-167-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 38 38 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 108 1 0 0 0 0 0

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-18.04
Fri Jul 1 01:15:27 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-20.04
Fri Jul 1 01:18:09 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = e5a27bb
Kernel= Linux 4.15.0-167-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 38 38 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 108 1 0 0 0 0 0

Signed-off-by: Michael Greenberg <michael.greenberg@stevens.edu>
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-18.04
Fri Jul 1 14:46:56 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS:ubuntu-20.04
Fri Jul 1 14:48:29 UTC 2022
intro: 2/2 tests passed.
interface: 38/38 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 2db5932
Kernel= Linux 4.15.0-167-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 38 38 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 108 1 0 0 0 0 0

@angelhof angelhof merged commit 8a3ca52 into future Jul 1, 2022
@angelhof angelhof deleted the drop-function-kw branch July 1, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants