Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kotlin DSL #324

Closed
wants to merge 3 commits into from
Closed

Conversation

DRSchlaubi
Copy link

No description provided.

- Add extension to make use of plugin easier when using Kotlin DSL
- Add example to README.md
- Add Kotlin to project

Signed-off-by: Michael Rittmeister <michael@rittmeister.in>
@eyalbe4
Copy link
Contributor

eyalbe4 commented May 3, 2020

Thanks you for this addition @DRSchlaubi!
Can you please add tests? You can look at the README for more information. Also, please let me know if you have any questions.

@DRSchlaubi
Copy link
Author

I've never used groovy and the last time I used the Groovy DSL is 3 years ago so it will take some time to understand the existing tests and probably find a way to not rewrite everything of it

@eyalbe4
Copy link
Contributor

eyalbe4 commented May 3, 2020

@DRSchlaubi,
Let me know if you have any questions about the tests. I'll try to assist.

@turansky
Copy link
Contributor

turansky commented May 3, 2020

@DRSchlaubi Benefit of new PR - new clean commits without ignored files at all
This PR contains ignored files (in first commit), which have not to be.

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
All committers have signed the CLA.

DRSchlaubi added a commit to DRSchlaubi/gradle-bintray-plugin that referenced this pull request Jan 15, 2021
- Code improvements

This also replaces  bintray#324
@DRSchlaubi DRSchlaubi closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants