Enable batched insert #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
approved these changes
May 5, 2023
src/anyvar/extras/vcf.py
Outdated
Comment on lines
33
to
35
| :param Optional[str] vcf_out: The path for the output VCF file | ||
| :param Optional[str] vrs_pickle_out: The path for the output VCF pickle file | ||
| :param str assembly: The assembly used in `vcf_in` data |
There was a problem hiding this comment.
I should make an issue in vrs-python for the paths to have type Path and not str
Suggested change
| :param Optional[str] vcf_out: The path for the output VCF file | |
| :param Optional[str] vrs_pickle_out: The path for the output VCF pickle file | |
| :param str assembly: The assembly used in `vcf_in` data | |
| :param vcf_out: The path for the output VCF file | |
| :param vrs_pickle_out: The path for the output VCF pickle file | |
| :param assembly: The assembly used in `vcf_in` data |
src/anyvar/storage/postgres.py
Outdated
Comment on lines
66
to
67
| :name: value for `vrs_id` field | ||
| :value: value for `vrs_object` field |
There was a problem hiding this comment.
Suggested change
| :name: value for `vrs_id` field | |
| :value: value for `vrs_object` field | |
| :param name: value for `vrs_id` field | |
| :param value: value for `vrs_object` field |
| def __init__(self, storage: PostgresObjectStore): | ||
| """Initialize context manager. | ||
|
|
||
| :param storage: Postgres instance to manage. Should be taken from the active |
There was a problem hiding this comment.
Suggested change
| :param storage: Postgres instance to manage. Should be taken from the active | |
| :param storage: Postgres instance to manage. Should be taken from the active | |
| :raises ValueError: If `storage` is not a `PostgresObjectStore` instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #37
Progress on #47