Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gembs #10109

Merged
merged 15 commits into from
Jul 27, 2018
Merged

Gembs #10109

Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes/gembs/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/bash

#instead of installing software from submodules, let them be dependencies

$PYTHON setup.py install --minimal --single-version-externally-managed --record=record.txt

61 changes: 61 additions & 0 deletions recipes/gembs/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
{% set version = "conda_v2" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be best if the version of the package reflected the actual version of the software.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. I'll have to ask for an up to date release. I'll definitely change this.

{% set sha256 = "1ead3f20a36a40c0737ec58c2e783b9c1cb6a9de0317c0009964d1b164c598a0" %}
{% set bcftoolsversion = "1.8" %}
{% set bcftoolssha256 = "4acbfd691f137742e0be63d09f516434f0faf617a5c60f466140e0677915fced"%}

package:
name: gembs
version: {{ version }}

source:
- url: https://github.com/karl616/gemBS/archive/{{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a fork from the original repo ? is the original one not being maintained anymore ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is leftovers from testing, connected to the funky version above. Should be changed.

sha256: {{ sha256 }}
- url: https://github.com/samtools/bcftools/releases/download/{{ bcftoolsversion }}/bcftools-{{ bcftoolsversion }}.tar.bz2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the bcftools source files being used ? its not obvious from the build.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is a custom compiled bcftools version installed to the python library location. It makes use of the plugin system of bcftools.
The installation script downloads bcftools, but I found it better to refer to it like this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but is the script going to use this one if its there ?
because if its going to download another one either way I think its best not to put this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script will prioritize the instance installed to the library folder, with a fall-back to the main-path.

The download process is part of a Makefile. If the folder is already populated by conda, the download step during installation will be skipped. So yes, the file referred here is the one being used.

sha256: {{ bcftoolssha256 }}
folder: tools/bcftools

build:
number: 0
skip: True # [py27]

requirements:
build:
- {{ compiler('c') }}
host:
- python >=3.0
- zlib
- bzip2
- xz
- htslib =1.8
- matplotlib
- multiprocess
- curl
- wget
run:
- python >=3.0
- zlib
- bzip2
- xz
- pigz
- htslib =1.8
- matplotlib
- multiprocess
- samtools =1.8
- gem3-mapper =3.6.1
- bs_call =2.02
- curl
- wget

test:
commands:
- gemBS

about:
home: https://github.com/heathsc/gemBS
license: GPL-3.0
license_file: LICENSE.md
summary: gemBS is a bioinformatics pipeline designed for high throughput analysis of DNA methylation from Whole Genome Bisulfite Sequencing data (WGBS).

extra:
identifiers:
- doi:10.1101/201988