feat: update valid snapshots

biomejs · Apr 18, 2024 · 40376f9 · 40376f9
1 parent 951cdd6
commit 40376f9
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 90 deletions.
diff --git a/crates/biome_css_analyze/src/lint/nursery/no_css_empty_block.rs b/crates/biome_css_analyze/src/lint/nursery/no_css_empty_block.rs
@@ -63,7 +63,7 @@ impl Rule for NoCssEmptyBlock {
             }
         } else if node.is_empty() {
             let has_comments_inside_block = node.r_curly_token().ok()?.has_leading_comments()
-                && node.l_curly_token().ok()?.has_trailing_comments();
+                || node.l_curly_token().ok()?.has_trailing_comments();
 
             if has_comments_inside_block {
                 return None;

diff --git a/crates/biome_css_analyze/tests/specs/nursery/noCssEmptyBlock/valid.css b/crates/biome_css_analyze/tests/specs/nursery/noCssEmptyBlock/valid.css
@@ -1,4 +1,4 @@
-@import "foo.css";
+/* CssDeclarationOrRuleBlock */
 a { color: pink; }
 a { /* foo */ }
 a {
@@ -11,6 +11,60 @@ a {
 a {
     /*\nfoo\nbar\n*/
 }
+
+/* CssRuleBlock */
 @media print { a { color: pink; } }
 @media print { a { /* foo */ } }
+
+/* CssDeclarationBlock */
+@font-palette-values --identifier {
+    font-family: Bixa;
+}
+
+@font-face {
+    font-family: "Trickster";
+    src:
+      local("Trickster"),
+      url("trickster-COLRv1.otf") format("opentype") tech(color-COLRv1),
+      url("trickster-outline.otf") format("opentype"),
+      url("trickster-outline.woff") format("woff");
+}
+
+/* CssKeyframesBlock */
+@keyframes slidein {
+    from {
+      transform: translateX(0%);
+    }
+
+    to {
+      transform: translateX(100%);
+    }
+}
+
+/* CssFontFeatureValuesBlock */
+@font-feature-values Font One {
+  @styleset {
+    nice-style: 12;
+  }
+}
+
+/* CssPageAtRuleBlock */
+@page {
+  size: 8.5in 9in;
+  margin-top: 4in;
+}
+@page :right {
+  size: 11in;
+  margin-top: 4in;
+}
+
+
+/* CssDeclarationOrAtRuleBlock */
+@page {
+  @top-right {
+    content: "Page " counter(pageNumber);
+  }
+}
+
+@import "foo.css";
 @import url(x.css)
diff --git a/crates/biome_css_analyze/tests/specs/nursery/noCssEmptyBlock/valid.css.snap b/crates/biome_css_analyze/tests/specs/nursery/noCssEmptyBlock/valid.css.snap
@@ -4,7 +4,7 @@ expression: valid.css
 ---
 # Input
 ```css
-@import "foo.css";
+/* CssDeclarationOrRuleBlock */
 a { color: pink; }
 a { /* foo */ }
 a {
@@ -17,102 +17,61 @@ a {
 a {
     /*\nfoo\nbar\n*/
 }
+
+/* CssRuleBlock */
 @media print { a { color: pink; } }
 @media print { a { /* foo */ } }
-@import url(x.css)
-```
-
-# Diagnostics
-```
-valid.css:3:3 lint/nursery/noCssEmptyBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! Unexpected empty block is not allowed
-  
-    1 │ @import "foo.css";
-    2 │ a { color: pink; }
-  > 3 │ a { /* foo */ }
-      │   ^^^^^^^^^^^^^
-    4 │ a {
-    5 │     /* foo */
-  
-  i Consider removing the empty block or adding styles inside it.
-  
-
-```
-
-```
-valid.css:4:3 lint/nursery/noCssEmptyBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! Unexpected empty block is not allowed
-  
-    2 │ a { color: pink; }
-    3 │ a { /* foo */ }
-  > 4 │ a {
-      │   ^
-  > 5 │     /* foo */
-  > 6 │ }
-      │ ^
-    7 │ a {
-    8 │     /* foo */
-  
-  i Consider removing the empty block or adding styles inside it.
-  
-
-```
 
-```
-valid.css:7:3 lint/nursery/noCssEmptyBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+/* CssDeclarationBlock */
+@font-palette-values --identifier {
+    font-family: Bixa;
+}
 
-  ! Unexpected empty block is not allowed
-  
-     5 │     /* foo */
-     6 │ }
-   > 7 │ a {
-       │   ^
-   > 8 │     /* foo */
-   > 9 │     /* bar */
-  > 10 │ }
-       │ ^
-    11 │ a {
-    12 │     /*\nfoo\nbar\n*/
-  
-  i Consider removing the empty block or adding styles inside it.
-  
+@font-face {
+    font-family: "Trickster";
+    src:
+      local("Trickster"),
+      url("trickster-COLRv1.otf") format("opentype") tech(color-COLRv1),
+      url("trickster-outline.otf") format("opentype"),
+      url("trickster-outline.woff") format("woff");
+}
 
-```
+/* CssKeyframesBlock */
+@keyframes slidein {
+    from {
+      transform: translateX(0%);
+    }
 
-```
-valid.css:11:3 lint/nursery/noCssEmptyBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+    to {
+      transform: translateX(100%);
+    }
+}
 
-  ! Unexpected empty block is not allowed
-  
-     9 │     /* bar */
-    10 │ }
-  > 11 │ a {
-       │   ^
-  > 12 │     /*\nfoo\nbar\n*/
-  > 13 │ }
-       │ ^
-    14 │ @media print { a { color: pink; } }
-    15 │ @media print { a { /* foo */ } }
-  
-  i Consider removing the empty block or adding styles inside it.
-  
+/* CssFontFeatureValuesBlock */
+@font-feature-values Font One {
+  @styleset {
+    nice-style: 12;
+  }
+}
 
-```
+/* CssPageAtRuleBlock */
+@page {
+  size: 8.5in 9in;
+  margin-top: 4in;
+}
+@page :right {
+  size: 11in;
+  margin-top: 4in;
+}
 
-```
-valid.css:15:18 lint/nursery/noCssEmptyBlock ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
-  ! Unexpected empty block is not allowed
-  
-    13 │ }
-    14 │ @media print { a { color: pink; } }
-  > 15 │ @media print { a { /* foo */ } }
-       │                  ^^^^^^^^^^^^^
-    16 │ @import url(x.css)
-  
-  i Consider removing the empty block or adding styles inside it.
-  
+/* CssDeclarationOrAtRuleBlock */
+@page {
+  @top-right {
+    content: "Page " counter(pageNumber);
+  }
+}
 
+@import "foo.css";
+@import url(x.css)
 ```