Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying Biolink 3.1.x to Prod: Organizing Items #578

Closed
tokebe opened this issue Mar 8, 2023 · 4 comments
Closed

Deploying Biolink 3.1.x to Prod: Organizing Items #578

tokebe opened this issue Mar 8, 2023 · 4 comments

Comments

@tokebe
Copy link
Member

tokebe commented Mar 8, 2023

Translator expects Biolink 3.1.1 and the new creative mode templates support to be deployed to Prod, with deployment requests going out by March 17. So, this issue stands to organize all related things to try and get done for this deployment request.

Summary of (Guaranteed) Changes

This section is to organize the changes so we can essentially copy-and-paste into our Change Request.

  • Multiple dependency upgrades for stability+security
  • Test rewrites to support testing of new features (irrelevant to deployment)
  • Final additions for qualifier support, upgrade to Biolink 3.1.1 (Add qualifiers biolink-model.js#32)
  • Support for new creative mode queries (PR)
  • Fixes for existing creative mode queries (PR)
  • Fix to attribute merging (PR)
  • Fix to is_set property when using node expansion (PR)

PRs currently on Dev waiting to be merged (aside from any of the above)

This section is subject to discussion regarding which PRs should be merged and bundled with this deployment

Issues that should be addressed and added before the deployment

These should probably be fixed before deployment, though it's up for discussion

@andrewsu
Copy link
Member

andrewsu commented Mar 8, 2023

I think this looks like a great plan to me. on #420, unless there is any reason to hold it up that I'm not remembering, yes, I think deploying that to prod would be good.

@colleenXu
Copy link
Collaborator

colleenXu commented Mar 9, 2023

The coordination of updating code vs updating SmartAPI yamls + refreshing the registry:

  • @tokebe would prefer removing overrides from code (dev, main) ➡️ auto-deploy to CI (with other fixes) ➡️ make ITRB request to update test/prod based on CI
  • When @tokebe deploys to dev/CI, also merge these PRs (biolink3, biolink3-text-mining) to update the SmartAPI yamls. Then ping @colleenXu or Chunlei to refresh the SmartAPI registry.
    • test/prod will be able to handle the SmartAPI yaml updates but creative-mode will be a bit wonky + the instances won't use qualifiers (this support is added with the other updates in the ITRB request)

@colleenXu
Copy link
Collaborator

Update:

@tokebe
Copy link
Member Author

tokebe commented Mar 28, 2023

All changes deployed to Prod 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants