Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize scores #576

Closed
tokebe opened this issue Mar 7, 2023 · 4 comments
Closed

Normalize scores #576

tokebe opened this issue Mar 7, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tokebe
Copy link
Member

tokebe commented Mar 7, 2023

BTE result scores currently have no upper bound. These scores should be normalized and bound to [0,1].

@andrewsu proposed a sigmoid function to cause scores to asymptotically approach 1. This makes a lot of sense, given that NGD scoring is unbound. We can simply clamp the low end at 0 as well.

Tagging @andrewsu @newgene for dicsussion.

@tokebe tokebe added enhancement New feature or request good first issue Good for newcomers labels Mar 7, 2023
@andrewsu
Copy link
Member

andrewsu commented Mar 7, 2023

I was thinking of a relatively crude transformation like this (and we can just eyeball the "right" value for the TUNING_PARAM)

https://colab.research.google.com/drive/1FgLR_iOon5W4gJv4-LZtbRkrJDJe7Y4x?usp=sharing

image

@tokebe
Copy link
Member Author

tokebe commented Mar 7, 2023

We could dynamically set the tuning parameter using some statistic of the untransformed set of scores?

@andrewsu
Copy link
Member

andrewsu commented Mar 8, 2023

My gut says we'd want to set a global tuning parameter to allow for the scenario where the answers for one query are truly much better/worse than another. That's how I'd propose we start by implementing it, and then we can examine how it works in practice.

@tokebe
Copy link
Member Author

tokebe commented May 12, 2023

Deployed to Prod.

@tokebe tokebe closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants