-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase 3: use qualifier-hierarchy when processing QGraph qualifier-constraints -> picking MetaEdges #598
Comments
Update notes: opening post was last updated 4/4 evening |
PRs made for this issue. The qualifier expansion is currently used for non-TRAPI APIs in the PR. Example Query I tested with (in the smartapi yaml for DGIdb, the constraints say activity, and biolink:causes respectively):{
"message": {
"query_graph": {
"nodes": {
"n0": {
"ids":["CHEMBL.COMPOUND:CHEMBL266510"]
},
"n1": {
"categories":["biolink:Gene"]
}
},
"edges": {
"e0": {
"subject": "n0",
"object": "n1",
"qualifier_constraints": [
{
"qualifier_set": [
{
"qualifier_type_id": "object_aspect_qualifier",
"qualifier_value": "activity_or_abundance"
},
{
"qualifier_type_id": "qualified_predicate",
"qualifier_value": "biolink:contributes_to"
}
]
}
]
}
}
}
}
} |
Hmm. I think it's fine that "qualifier" expansion isn't done with TRAPI KPs right now. I think we'd need #597 addressed, and then we could think if qualifier expansion is needed to match the qualifier-constraints to MetaEdges from TRAPI KPs that have qualifier info... |
Appears to work. In this testing, BTE had console logs showing that Automat hetio's meta_knowledge_graph shows that there's a SmallMolecule - regulates - console logs showing the qualifier hierarchy expansion
Closing issue |
We'd like to be able to traverse the qualifier hierarchy (similar to what we do with predicates and node categories), so we can correctly retrieve all the operations/MetaEdges that correspond to a particular qualifier-constraint from the original query QEdge...
this may come up as a potential issue as more querying is done with qualifier-constraints
Notes:
The text was updated successfully, but these errors were encountered: