Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feb 2024 - Remove overrides/changes that are no longer needed #784

Closed
colleenXu opened this issue Feb 21, 2024 · 8 comments
Closed

Feb 2024 - Remove overrides/changes that are no longer needed #784

colleenXu opened this issue Feb 21, 2024 · 8 comments
Labels
On Test Related changes are deployed to Test server

Comments

@colleenXu
Copy link
Collaborator

Now that the code for the following issues has been deployed in Prod (Feb Translator release), I've merged the SmartAPI yaml changes into the master branch (registered yamls).

We can now go through the process of removing the overrides biothings/bte-server#4 and biothings/bte-server@28e5b58

@colleenXu
Copy link
Collaborator Author

We should be able to add the removal of the v3 Monarch API override biothings/bte-server#16 to this issue + PR.

It depends on how the timeline of the v3 Monarch API special deployment goes, VS the next release's deployments.

@colleenXu colleenXu changed the title Remove overrides that are no longer needed Remove overrides/changes that are no longer needed Feb 23, 2024
@colleenXu
Copy link
Collaborator Author

colleenXu commented Feb 23, 2024

Adding the revert of biothings/bte_trapi_query_graph_handler#178, which is no longer needed due to the changes in biothings/api-respone-transform.js#63. See #783 (comment)

@colleenXu
Copy link
Collaborator Author

@colleenXu
Copy link
Collaborator Author

The v3 Monarch changes have been deployed to BTE prod and the yaml/registration has been updated. So we can continue the plan to remove the override with this PR. biothings/bte-server#17

However, I've added an additional chore to this PR: updating name of API in API_LIST biothings/bte-server@067b820: from "Biolink API" -> "Monarch API" to reflect the SmartAPI yaml update

@colleenXu
Copy link
Collaborator Author

Note that we basically probably remove these overrides just to replace them with new overrides for #788

@tokebe tokebe added On CI Related changes are deployed to CI server On Test Related changes are deployed to Test server and removed On CI Related changes are deployed to CI server labels Mar 7, 2024
@tokebe
Copy link
Member

tokebe commented Apr 17, 2024

This issue may as well stay open as a rolling issue-- we'll almost constantly have a stream of new overrides that need to be removed as releases make it to Prod.

@colleenXu
Copy link
Collaborator Author

Jackson and I discussed this and decided to close this. I'll make another issue for removing the temporary changes and we'll see if the "rolling" format works.

@colleenXu colleenXu changed the title Remove overrides/changes that are no longer needed Feb 2024 - Remove overrides/changes that are no longer needed Apr 18, 2024
@colleenXu
Copy link
Collaborator Author

Now that this is deployed to Prod, I went through and deleted the old SmartAPI yaml branches that were used for overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Test Related changes are deployed to Test server
Projects
None yet
Development

No branches or pull requests

2 participants