Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store attribute values as array instead of set #880

Closed
tokebe opened this issue Oct 3, 2024 · 3 comments
Closed

Store attribute values as array instead of set #880

tokebe opened this issue Oct 3, 2024 · 3 comments
Assignees
@rjawesome
Labels
On Test Related changes are deployed to Test server

Comments

@tokebe
Copy link
Member

tokebe commented Oct 3, 2024

First described here

Because we store attribute values as a set, any value that is supposed to be an additive number (for instance evidence_count) can be added incorrectly if there are duplicate values (as they'd be squashed by the set).

Instead of this, we can change attribute value storage to an Array, and then handle set cases for array-type TRAPI attributes in our TRAPI attribute generation.
@tokebe
Copy link
Member Author

tokebe commented Oct 3, 2024

Medium-low priority.

@rjawesome rjawesome mentioned this issue Oct 4, 2024
Merged
@rjawesome
Copy link
Contributor

see pr

@colleenXu colleenXu mentioned this issue Oct 21, 2024
Closed
@colleenXu colleenXu added the On CI Related changes are deployed to CI server label Oct 22, 2024
@colleenXu colleenXu mentioned this issue Oct 22, 2024
Open
@colleenXu colleenXu added On CI -> Test and removed On CI Related changes are deployed to CI server labels Oct 23, 2024
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI -> Test labels Oct 28, 2024
@tokebe
Copy link
Member Author

tokebe commented Dec 3, 2024

Related changes deployed to Prod as of 11/13

@tokebe tokebe closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjawesome rjawesome

Labels
On Test Related changes are deployed to Test server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rjawesome @tokebe @colleenXu