Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualifiers #129

Merged
merged 39 commits into from
Dec 21, 2022
Merged

Add qualifiers #129

merged 39 commits into from
Dec 21, 2022

Conversation

tokebe
Copy link
Member

@tokebe tokebe commented Dec 9, 2022

(Using new QEdge refactor) Support qualifier representation & data flow in QEdge. Update creative-mode templates, tests, etc.

Related PRs:

rjawesome and others added 30 commits September 28, 2022 18:15
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #129 (7af3960) into main (ed09bbe) will decrease coverage by 10.98%.
The diff coverage is 42.34%.

❗ Current head 7af3960 differs from pull request most recent head e51bb36. Consider uploading reports for the commit e51bb36 to get more accurate results

@@             Coverage Diff             @@
##             main     #129       +/-   ##
===========================================
- Coverage   70.79%   59.81%   -10.99%     
===========================================
  Files          26       25        -1     
  Lines        2332     2354       +22     
===========================================
- Hits         1651     1408      -243     
- Misses        681      946      +265     
Impacted Files Coverage Δ
src/biolink.js 75.75% <0.00%> (-24.25%) ⬇️
src/inferred_mode/template_lookup.js 72.00% <0.00%> (-1.47%) ⬇️
src/query_edge.js 26.10% <17.69%> (-64.81%) ⬇️
src/inferred_mode/inferred_mode.js 64.10% <35.29%> (-0.15%) ⬇️
src/edge_manager.js 25.84% <37.25%> (-39.89%) ⬇️
src/graph/graph.js 48.14% <50.00%> (-22.37%) ⬇️
src/graph/kg_edge.js 54.90% <50.00%> (-5.52%) ⬇️
src/graph/knowledge_graph.js 28.75% <57.14%> (-8.10%) ⬇️
src/query_node.js 60.00% <57.89%> (-23.51%) ⬇️
src/index.js 70.37% <61.11%> (-7.41%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tokebe tokebe mentioned this pull request Dec 9, 2022
@colleenXu
Copy link
Contributor

@tokebe
Copy link
Member Author

tokebe commented Dec 14, 2022

Update pushed, now addresses biothings/biothings_explorer#534

@tokebe tokebe merged commit 17ecb35 into main Dec 21, 2022
@tokebe tokebe deleted the add-qualifiers branch November 29, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants