Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary knowledge refactor #137

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Primary knowledge refactor #137

merged 4 commits into from
Mar 15, 2023

Conversation

rjawesome
Copy link
Contributor

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #137 (3fffbd9) into main (66a9b28) will increase coverage by 0.13%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   60.43%   60.57%   +0.13%     
==========================================
  Files          25       25              
  Lines        2449     2445       -4     
==========================================
+ Hits         1480     1481       +1     
+ Misses        969      964       -5     
Impacted Files Coverage Δ
src/graph/knowledge_graph.js 30.00% <40.00%> (+2.61%) ⬆️
src/index.js 70.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@colleenXu
Copy link
Contributor

colleenXu commented Mar 9, 2023

@tokebe @rjawesome I think something is still off on the logic (perhaps here).

For Multiomics EHR Risk and Multiomics Wellness (don't worry about Litvar), the API-infores is completely missing...it's supposed to be there under the primary_knowledge_source attribute_type_id...

(Note: test with this PR biothings/biothings_explorer#567)

before and after: Multiomics Wellness KP Edge

before: infores:biothings-multiomics-wellness should be under a primary_knowledge_source attribute_type_id
Screen Shot 2023-03-09 at 12 45 40 PM

after: the infores:biothings-multiomics-wellness is completely missing
Screen Shot 2023-03-09 at 1 24 01 PM

before and after: Multiomics EHR risk KP

before: infores:biothings-multiomics-ehr-risk should be under a primary_knowledge_source attribute_type_id
Screen Shot 2023-03-09 at 1 02 53 PM

after: infores:biothings-multiomics-ehr-risk is completely missing
Screen Shot 2023-03-09 at 1 23 44 PM

@rjawesome
Copy link
Contributor Author

Should be fixed

@colleenXu
Copy link
Contributor

colleenXu commented Mar 10, 2023

@rjawesome retested with the latest commit and yeah, it looks fixed.

This PR (together with this one) are good from my POV @tokebe.

Multiomics Wellness KP Edge

Screen Shot 2023-03-09 at 11 00 40 PM

Multiomics EHR Risk KP Edge

Screen Shot 2023-03-09 at 11 01 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants