Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing transformer field on operations #61

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

rjawesome
Copy link
Contributor

@rjawesome rjawesome marked this pull request as draft November 15, 2022 01:58
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #61 (3d38e32) into main (874e120) will decrease coverage by 0.19%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   85.16%   84.98%   -0.19%     
==========================================
  Files          30       30              
  Lines         755      759       +4     
  Branches      164      163       -1     
==========================================
+ Hits          643      645       +2     
- Misses        111      113       +2     
  Partials        1        1              
Files Coverage Δ
..._builder/async_operations_builder_with_reasoner.ts 40.29% <ø> (ø)
...s_builder/sync_operations_builder_with_reasoner.ts 84.00% <ø> (ø)
src/parser/endpoint.ts 97.05% <100.00%> (ø)
src/parser/query_operation.ts 92.00% <50.00%> (-3.66%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rjawesome
Copy link
Contributor Author

TODO:

  • check over async operations builder
  • test the ref (theoretically should work)
  • do for trapi apis in bte package

@tokebe
Copy link
Member

tokebe commented Mar 28, 2023

@rjawesome Tests re-ran after I pushed a merge of the latest from main. There are definitely some failing tests. If this PR is required to support biothings/api-respone-transform.js#38, please fix these tests and mark the PR as ready for review.

@rjawesome
Copy link
Contributor Author

Tests are fixed (the X is for coverage not the tests)

@rjawesome rjawesome changed the title Processing x-bte-transformer field Processing transformer field on operations Sep 28, 2023
@colleenXu colleenXu removed their request for review October 3, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants